Just curious if you had thought about adding the possibility to work with colorbox?

Comments

webadpro’s picture

Status: Active » Needs review
StatusFileSize
new6.93 KB

Hi,

Since I needed this feature, I have added a patch to do so. A new display formatter has been added if colorbox module exsits.

Please review.

webadpro’s picture

Title: work with Colorbox? » Load videos in colorbox.

Changed Title

thechanceg’s picture

Thank you for the patch! I just tried applying it and got a few errors. This is against the 7.x-2.x-dev branch released Nov 7.

colorbox.patch:25: trailing whitespace.
  
colorbox.patch:44: trailing whitespace.
  
colorbox.patch:74: trailing whitespace.
        $element[$delta] = array(          
colorbox.patch:83: trailing whitespace.
        );      
colorbox.patch:88: trailing whitespace.
        );    
Checking patch video_embed_field.field.inc...
Checking patch video_embed_field.info...
warning: video_embed_field.info has type 100644, expected 100755
error: while searching for:
configure = admin/config/media/vef_video_styles

dependencies[] = ctools
dependencies[] = image
error: patch failed: video_embed_field.info:5
error: video_embed_field.info: patch does not apply
Checking patch video_embed_field.module...

Do you have any idea what I am running up against? Is this patch for a different version?

Thank you for any help you might be able to provide. This patch is the last missing piece of the puzzle :)

webadpro’s picture

The patch has been made from the branch 7.x-2.x.

thechanceg’s picture

I'm sorry if I wasn't clear enough. I was trying to apply the patch to the 7.x-2.x branch.

I was able to get you code to work by editing the code manually, (it is awesome!), but I could not get the patch to apply. Maybe it is something with how the patch was made? I would be happy to try rolling a version of the patch if you want, just let me know.

webadpro’s picture

Sure, no problem.

thechanceg’s picture

StatusFileSize
new13.04 KB

I tried re-rolling that patch. Hopefully this will help some people out. Big thanks to webadpro for all the work.

webadpro’s picture

Great :)

hydra’s picture

Status: Needs review » Reviewed & tested by the community

Patch worked perfectly for me. For all who are apllying this patch, donÄt forget to enable inline support for colorbox at admin/config/media/colorbox!

Thanks to thechanceg and webadpro for the right patch at the right moment, safed me alot of work.

webadpro’s picture

Hydra, right.

I did forget to mention to enable inline support for colorbox.

Thanks for noting.

jec006’s picture

Committed here: http://drupalcode.org/project/video_embed_field.git/commit/d887494 I gave the attribution to webadpro as he wrote the initial patch. Thanks to all of you for the work.

I also committed a follow up here: http://drupalcode.org/project/video_embed_field.git/commit/cd115b3 which includes:

Better support for original image format - it was breaking again.

Better integration with the colorbox module : I added an update hook to enable the support that we need by default (inline colorbox) so people won't have to go configure that.

If you guys could test a bit and let me know if anything isn't working before i roll a new release that would be awesome

jec006’s picture

Status: Reviewed & tested by the community » Fixed
webadpro’s picture

Happy to see it in the module itself :)

Glad we could get it all working together :)

mrtalloy’s picture

Category: feature » bug
Status: Fixed » Needs review

This works great guys - it's good to finally be able to do this!

The only one noticeable issue happens when using views/colorbox. If the Video Style is set to autoplay (which would be cool when launching it in colorbox) the sound plays before you actually click the thumbnail preview. I'm guessing that also means the video is loading too. I've only tested Vimeo so far

hydra’s picture

@mrtalloy: Yeah you're absolutly right. The Vies integration just loads the content in a hidden div container wich is used as inline content for the colorbox. If you set the video to autoplay, it will start right after the pageload. But this is an other issue, maybe you will open a feature request issue for this.

jec006’s picture

Status: Needs review » Fixed

I created another issue for this:
#1387020: Autoplay videos in colorbox will play before color box open

I'm gonna mark this one as fixed as the idea is implemented and work on this in the other issue. Thanks guys.

webadpro’s picture

Hey Guys,

I've runned into this issue also, although I simply choosed to not auto start the videos.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.