Closed (fixed)
Project:
Video Embed Field
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Nov 2011 at 16:16 UTC
Updated:
13 Jan 2012 at 21:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
webadpro commentedHi,
Since I needed this feature, I have added a patch to do so. A new display formatter has been added if colorbox module exsits.
Please review.
Comment #2
webadpro commentedChanged Title
Comment #3
thechanceg commentedThank you for the patch! I just tried applying it and got a few errors. This is against the 7.x-2.x-dev branch released Nov 7.
Do you have any idea what I am running up against? Is this patch for a different version?
Thank you for any help you might be able to provide. This patch is the last missing piece of the puzzle :)
Comment #4
webadpro commentedThe patch has been made from the branch 7.x-2.x.
Comment #5
thechanceg commentedI'm sorry if I wasn't clear enough. I was trying to apply the patch to the 7.x-2.x branch.
I was able to get you code to work by editing the code manually, (it is awesome!), but I could not get the patch to apply. Maybe it is something with how the patch was made? I would be happy to try rolling a version of the patch if you want, just let me know.
Comment #6
webadpro commentedSure, no problem.
Comment #7
thechanceg commentedI tried re-rolling that patch. Hopefully this will help some people out. Big thanks to webadpro for all the work.
Comment #8
webadpro commentedGreat :)
Comment #9
hydra commentedPatch worked perfectly for me. For all who are apllying this patch, donÄt forget to enable inline support for colorbox at admin/config/media/colorbox!
Thanks to thechanceg and webadpro for the right patch at the right moment, safed me alot of work.
Comment #10
webadpro commentedHydra, right.
I did forget to mention to enable inline support for colorbox.
Thanks for noting.
Comment #11
jec006 commentedCommitted here: http://drupalcode.org/project/video_embed_field.git/commit/d887494 I gave the attribution to webadpro as he wrote the initial patch. Thanks to all of you for the work.
I also committed a follow up here: http://drupalcode.org/project/video_embed_field.git/commit/cd115b3 which includes:
Better support for original image format - it was breaking again.
Better integration with the colorbox module : I added an update hook to enable the support that we need by default (inline colorbox) so people won't have to go configure that.
If you guys could test a bit and let me know if anything isn't working before i roll a new release that would be awesome
Comment #12
jec006 commentedComment #13
webadpro commentedHappy to see it in the module itself :)
Glad we could get it all working together :)
Comment #14
mrtalloy commentedThis works great guys - it's good to finally be able to do this!
The only one noticeable issue happens when using views/colorbox. If the Video Style is set to autoplay (which would be cool when launching it in colorbox) the sound plays before you actually click the thumbnail preview. I'm guessing that also means the video is loading too. I've only tested Vimeo so far
Comment #15
hydra commented@mrtalloy: Yeah you're absolutly right. The Vies integration just loads the content in a hidden div container wich is used as inline content for the colorbox. If you set the video to autoplay, it will start right after the pageload. But this is an other issue, maybe you will open a feature request issue for this.
Comment #16
jec006 commentedI created another issue for this:
#1387020: Autoplay videos in colorbox will play before color box open
I'm gonna mark this one as fixed as the idea is implemented and work on this in the other issue. Thanks guys.
Comment #17
webadpro commentedHey Guys,
I've runned into this issue also, although I simply choosed to not auto start the videos.