The CRUD UI pages have their titles doubly encoded.

In entity_ui_form_defaults, drupal_set_title is used to assign the page title based on the result of entity_ui_get_page_title. entity_ui_get_page_title is encoded at this stage because it uses t() with '@' substitution. When this label is then passed to drupal_set_title, it is then encoded a second time.

I don't know if it would be better to change the '@' in the t() calls to '!', or to add PASS_THROUGH to the drupal_set_title call.

CommentFileSizeAuthor
#1 entity-encoding-1336806-1.patch775 bytesloganfsmyth

Comments

loganfsmyth’s picture

loganfsmyth commented
Status: Active » Needs review
StatusFileSize
new entity-encoding-1336806-1.patch775 bytes

Here's a patch changing it to PASS_THROUGH, but changing the t() calls would work just as well.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

thanks, patch looks good. PASS_THROUGH is fine, as that way we can keep existing translation strings as well the way menu items are generated.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.