Download & Extend

Rebuild code incorrect

Project:Strongarm
Version:7.x-2.0-beta4
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

The current if statement for "variable_features_rebuild" reads;

if (!empty($vars[$name]->in_code_only) || (drupal_installation_attempted() && $vars[$name]->export_type & EXPORT_IN_CODE)) {

This prevents a rebuild if you've followed these steps;

drush @dev site-install standard ... **params**
drush @dev pm-enable features feature_stroopwafel

The reason being, in_code_only is NOT set and also, drupal_installation_attempted returns FALSE.

I'm assuming that drupal_installation_attempted() is included in case this hook is being called from an installation profile but I don't see why that's relevant? If a Features module is enabled don't you always want the feature rebuild to be run? Also, grep-ing for "in_code_only" doesn't really tell me anything useful...

Pobster