Primary term not assigned to the right node

zigazou - April 4, 2007 - 14:31
Project:Primary Term
Version:4.7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Incorrect use of vid instead of nid in term_node table

The INSERT INTO term_node query assign $node->vid to the nid field of term_node table. It should assign $node->nid.

It works until a revision is created (when $nid and $vid are no more synchronised with each other).

Patch is supplied.

Have I got it right ?

AttachmentSize
patch_0_0.txt488 bytes

#1

zigazou - April 4, 2007 - 14:47

It is apparently the same for the 5.x-1.x-dev version of the module.

#2

bjaspan - October 12, 2007 - 15:27
Status:needs review» fixed

You appear to be correct. Primary Term assigns the PT to a vid but taxonomy.module (in D5) assigns terms to nids; this is probably what led to the confusion. Anyway, I fixed the module not to muck directly with the term_node table at all, using nodeapi('submit') instead, which also fixed this bug.

I am not maintaining the 4.7 branch of PT any more; if someone comes along that wants to back-port fixes, I'll add them to the CVS access list.

#3

Anonymous - October 26, 2007 - 15:31
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.