Similar to the approach in #1336886: Remove id3 demo directory let's remove the unnecessary _samples directory from CKEditor.

CommentFileSizeAuthor
#8 1337004-ckeditor-remove-samples-4.patch226.92 KBezra-g
#3 1337004-ckeditor-remove-samples-3.patch231.7 KBezra-g
#2 ckeditor-remove-samples-2.patch187.53 KBezra-g
#1 ckeditor-remove-samples.patch405.29 KBezra-g

Comments

ezra-g’s picture

ezra-g commented
Status: Active » Needs review
StatusFileSize
new ckeditor-remove-samples.patch405.29 KB

Here's a patch that goes along with a 1337004-ckeditor-remove-samples branch.

ezra-g’s picture

ezra-g commented
StatusFileSize
new ckeditor-remove-samples-2.patch187.53 KB

Revised patch without .svn metadata (ghasp).

ezra-g’s picture

ezra-g commented
StatusFileSize
new 1337004-ckeditor-remove-samples-3.patch231.7 KB

After further investigation, we need to use a binary diff in order to remove the .swf files.

laurentc’s picture

laurentc commented

The patch looks good.

laurentc’s picture

laurentc commented
Status: Needs review » Reviewed & tested by the community

Reviewed.

ezra-g’s picture

ezra-g commented
Status: Reviewed & tested by the community » Fixed

This is committed via http://drupalcode.org/project/commons.git/commitdiff/2f1a8c3?hp=a494f222....

Note: I accidentally merged in my development branch into 6.x-2.x instead of committing directly to 6.x-2.x with a patch/clear commit message. My mistake. Luckily, the branch name still references this issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ezra-g’s picture

ezra-g commented
Status: Closed (fixed) » Needs review
StatusFileSize
new 1337004-ckeditor-remove-samples-4.patch226.92 KB

This patch stopped applying so I re-rolled it. It looks like the CKEditor tarball may have changed since we rolledit, even though the tarball refers to a specific version and we haven't changed the download URL :\.

Attached is a re-roll of #3 based on the apparently new tarball.

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

http://drupalcode.org/project/commons.git/commit/8f0ca96

mstef’s picture

mstef commented

Updated, but I have a feeling this is my fault somehow:

ckeditor downloaded from http://download.cksource.com/CKEditor/CKEditor/CKEditor%203.6.2/ckeditor_3.6.2.tar.gz.                                    [ok]
Unable to patch ckeditor with 1337004-ckeditor-remove-samples-4.patch.  [error]

I did try downloading the package and patch manually, and I'm unable to apply it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.