When using the Yes/No widget, I edit the settings to set an Expiration Setting (to 1 week and to allow overriding in the node), and I save the module. Then, if I hit the edit button again and scroll back down to the Expiration settings, the setting reverts back to "never" and the "allow override" button is not checked.

Thus, this functionality is broken in the module.

Thanks for your help.

CommentFileSizeAuthor
#8 rate-reference-parameter-1386810-0.patch1.98 KBNorberto Ostallo

Comments

web360’s picture

web360 commented

Can confirm issue with expiration settings not saving.

Install Details
Drupal 7.9 running on Windows Server 2008 R2, IIS 7.5, MS SQL 2008.

mauritsl’s picture

mauritsl commented
Status: Active » Fixed

Fix was commited to GIT.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Tosh’s picture

Tosh commented
Version: 7.x-2.x-dev » 7.x-1.3
Assigned: Unassigned » Tosh
Status: Closed (fixed) » Active

I get this error

earwax’s picture

earwax commented

I also have this problem in 7.x-1.3. The expiration does not save.

cospace’s picture

cospace commented

same problem here, any solution so far?

Warning: Parameter 1 to rate_expiration_rate_widget_update() expected to be a reference, value given in the module_invoke_all (line819)

Norberto Ostallo’s picture

Norberto Ostallo commented

Check this issue for a solution http://drupal.org/node/1386810

Norberto Ostallo’s picture

Norberto Ostallo commented
Status: Active » Needs review
StatusFileSize
new rate-reference-parameter-1386810-0.patch1.98 KB

This is a patch that solves the problem.

mauritsl’s picture

mauritsl commented
Assigned: Tosh » Unassigned
Status: Needs review » Fixed

Comitted to GIT. Thanks for the patch!

Will be available in 7.x-1.4 release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

msypes’s picture

msypes commented
Issue summary: View changes
Status: Closed (fixed) » Needs review

This problem is still here. Just installed the module, and my very first attempt to save widget parameters gave this:

Warning: Parameter 1 to rate_expiration_rate_widget_update() expected to be a reference, value given in module_invoke_all() (line 895 ... /includes/module.inc).

and as noted above, the expiration resets to never and the override checkbox reverts to unchecked.

  • mauritsl committed ce98205 on 8.x-1.x 
    Issue #1337010: Fix rate_expiration settings not saving.
  • mauritsl committed 3b81b38 on 8.x-1.x
    Issue #1337010 by earwax, norberto.ostallo: Fix expiration settings not...
ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Closed (outdated)

Drupal 7 is EOL. Issue will be closed, but patches are still here

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.