Problem/Motivation

We can convert /aggregator to a view. This gives more flexibility to the sitebuilder and is more consistent to what other modules are doing.

Remaining tasks

Figure out whether views should be a dependency to aggregator or not. If it shouldn't be then we need to add a fallback to the current patch in case views is not installed.

User interface changes

None

API changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, as a part of #1823450: [Meta] Convert core listings to Views
Issue priority Major, as a part of #1823450: [Meta] Convert core listings to Views
Prioritized changes It reduces fragility by re-using views code and getting rid of custom listing code.
It is also the last aggregator route to be converted to a view, which makes things more consistent
Disruption There is no API change, since controllers are not considered public API. Only disruption would be for existing D8 sites running aggregator with views disabled (not many if any at all, since all other public aggregator's listing are converted to views already - see parent)
CommentFileSizeAuthor
#8 drupal-aggregator-1337018-8.patch4.79 KBgeertvd
#8 interdiff-1337018-6-8.txt1.25 KBgeertvd
#6 drupal-aggregator-1337018-6.patch5.28 KBgeertvd
#3 drupal-aggregator-1337018-4.patch5.64 KBParisLiakos
#3 interdiff-1337018.txt3.12 KBParisLiakos
#2 drupal-aggregator-1337018.patch2.53 KBParisLiakos

Comments

ParisLiakos’s picture

ParisLiakos commented
Title: Add variable for aggregator pager » Convert /aggregator to a view
Category: Feature request » Task
Issue summary: View changes
Issue tags: +VDC
Parent issue: » #1955760: [Meta] Convert aggregator pages/blocks to views

Or, you know; convert it to a view ;)

ParisLiakos’s picture

ParisLiakos commented
Status: Active » Needs review
StatusFileSize
new drupal-aggregator-1337018.patch2.53 KB

this should be it

ParisLiakos’s picture

ParisLiakos commented
StatusFileSize
new interdiff-1337018.txt3.12 KB
new drupal-aggregator-1337018-4.patch5.64 KB

uh, this time with also removing the dead code

jibran queued 3: drupal-aggregator-1337018-4.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: drupal-aggregator-1337018-4.patch, failed testing.

geertvd’s picture

geertvd commented
Status: Needs work » Needs review
StatusFileSize
new drupal-aggregator-1337018-6.patch5.28 KB

Reroll

Status: Needs review » Needs work

The last submitted patch, 6: drupal-aggregator-1337018-6.patch, failed testing.

geertvd’s picture

geertvd commented
StatusFileSize
new interdiff-1337018-6-8.txt1.25 KB
new drupal-aggregator-1337018-8.patch4.79 KB
geertvd’s picture

geertvd commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Nice work!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: drupal-aggregator-1337018-8.patch, failed testing.

Status: Needs work » Needs review

geertvd queued 8: drupal-aggregator-1337018-8.patch for re-testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Passes on CI so back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update

Does aggregator now depend on views?

Also the beta evaluation is not convincing. This is disruptive for site using aggregator but not views.

geertvd’s picture

geertvd commented
Version: 8.0.x-dev » 8.1.x-dev
Issue summary: View changes
Status: Needs work » Postponed

I'm thinking it shouldn't be dependent on views, we might have to look into #1963544: Convert aggregator/rss to views also then since the rss feed is not available when views is disabled, I created a followup for that in #2553781: /aggregator/rss is not available when views is not installed.

Talked with alexpott via IRC on this and he think this might not be beta applicable so changing this to postponed right now.

ParisLiakos’s picture

ParisLiakos commented
Version: 8.1.x-dev » 8.0.x-dev
Issue summary: View changes
Priority: Normal » Major
Status: Postponed » Reviewed & tested by the community
Issue tags: -Needs issue summary update

Does aggregator now depend on views?

No, see #1864980: [meta] Figure out how to integrate Views into core

Also see #1823450: [Meta] Convert core listings to Views since this is a child of it which is major.

If those issues are not beta compatible the parent issue should be pushed to 8.1.x

ParisLiakos’s picture

ParisLiakos commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review

Is /aggregator a supplementary feature of the module? To me it seems a pretty central feature - so shouldn't it have a fallback?

ParisLiakos’s picture

ParisLiakos commented
Version: 8.0.x-dev » 8.2.x-dev
Parent issue: #1955760: [Meta] Convert aggregator pages/blocks to views » #1823450: [Meta] Convert core listings to Views

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

quietone’s picture

quietone commented
Status: Needs review » Closed (duplicate)
Related issues: +#1821844: Aggregator views integration, +#2154781: Convert aggregator/sources and aggregator/opml to views, +#1963544: Convert aggregator/rss to views

Surely this is fixed.

Yes work on this was in done in #1963544: Convert aggregator/rss to views and #2154781: Convert aggregator/sources and aggregator/opml to views. Closing as a duplicate.