Posted by ptundo on April 4, 2007 at 4:34pm
3 followers
| Project: | Javascript Tools |
| Version: | 5.x-0.6 |
| Component: | Jscalendar |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
First day of the week is undefined in calendar-it.js, so the issue.
The patch is attached.
| Attachment | Size |
|---|---|
| calendar-it.js_.patch | 135 bytes |
Comments
#1
All but 8 locales miss that setting.
calendar-af.js, calendar-cs-win.js, calendar-lt.js, calendar-pt.js, calendar-tr.js, calendar-al.js, calendar-da.js, calendar-he-utf8.js, calendar-lt-utf8.js, calendar-ro.js, calendar-zh.js, calendar-hr-utf8.js, calendar-lv.js, cn_utf8.js, calendar-big5.js, calendar-du.js, calendar-hu.js, calendar-nl.js, calendar-big5-utf8.js, calendar-el.js, calendar-it.js, calendar-si.js, calendar-br.js, calendar-jp.js, calendar-no.js, calendar-sk.js, calendar-ca.js, calendar-ko.js, calendar-pl.js, calendar-sp.js, calendar-cs-utf8.js, calendar-fi.js, calendar-ko-utf8.js, calendar-pl-utf8.js
are currently affected.
Thanks for spotting this ptundo, who knows how much time I'd have wasted if I hadn't noticed this thread.
#2
In all fairness, it is a problem in the jscalendar project itself.
Still, a check for this problem when updating won't hurt.
#3
If you send a proper patch or replacement-file I'll commit it to CVS.
#4
On (GNU-)Linux systems from the CLI: (root directory of the jstools module)
[USER jstools]$ for item in `grep -L "^Calendar._FD" jscalendar/lib/lang/*js`; do [ -f "${item}" ] && echo -e "\n\nCalendar._FD = 1;" >> ${item}; doneAnyway, the patch is proper enough?
#5
I don't like setting the variable everywhere to 1, but I agree that having it set is better than having it not set at all.
I redid the modification with a slightly modified script that also adds a comment as to what Calendar_FD means, but otherwise it's the same.
Applied to all branches.
If you think we got the wrong day for your country just speak up ...
#6