I'm not 100% on this, but shouldn't fboauth_create_user() use module_invoke_all('fboauth_user_save') instead of this (from fboauth.fboauth.inc) or is this designed as a performance enhancement?:

  foreach (module_implements('fboauth_user_save') as $module) {
    $function = $module . '_fboauth_user_save';
    $function($account, $fbuser);
  }

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Closed (works as designed)

Well first of all, module_invoke_all() doesn't have a performance advantage, but the real reason why we're not using it here is because we need to pass $account and $fbuser by reference. If you using module_invoke_all(), it will use call_user_func_array(), which breaks pass-by-reference arguments.