It would be great if there was a permission that could allow / restrict users to assign domain paths to only their assigned domains. I have 4 domains, and one of my users is assigned to only one domain to create content. However, they have access to write domain paths for all 4 domains.
Even though their content will only be published to the single domain they are assigned to, if they enter alias' in other domains, and another user later decides to publish this content to the other domains and does not check the domain paths, then these paths will go live.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 1337500-11-domain_path-field_access.patch | 13.16 KB | grndlvl |
| #10 | 1337500-9-domain_path-field_access.patch | 7.49 KB | grndlvl |
| #8 | 1337500-8-domain_path-field_access.patch | 4.85 KB | grndlvl |
| #6 | 1337500-6.patch | 2.32 KB | les lim |
| #3 | 1337500.patch | 1.19 KB | apemantus |
Comments
Comment #1
agentrickardE.g. only expose the form elements for the domains the user controls? Right?
Comment #2
karnal69 commentedExactly. If they are only assigned to domain A, they should only be able to set a domain path for domain A and not domain B, C etc as well.
Comment #3
apemantus commentedI wanted this feature as well, so here's a quick patch. One thing I haven't done is check what happens with "delete domain specific aliases" - a user assigned to just domain A should not be able to delete paths for domains B&C.
Comment #4
agentrickardPlease set new patches to 'needs review.'
Comment #5
agentrickardBoth actions should probably get a separate permission if we go this route.
1) "Delete path aliases for all domains"
2) "Create path aliases for assigned domains"
Users who cannot delete aliases can leave them empty, which should delete them.
Comment #6
les limHere's apemantus's patch from #3 re-worked to incorporate the new permissions.
Still "needs work" because domain_path_node_insert() needs to accommodate the possibility of altering only one domain at a time. Right now the function deletes all existing domain paths right from the start, so if you only had access to change the path for one domain, all other domain paths are lost upon save. This is perhaps a different issue, but it's a blocker for this patch.
Comment #7
les limPosted a blocker issue: #1425292: domain_path_node_insert() should update existing records rather than deleting/recreating them
Comment #8
grndlvl commentedRe-rolled against recent changes to API and User interface.
I will try to go ahead and work on some tests as well.
Comment #9
grndlvl commentedAlso we need to update the in line documentation.
Comment #10
grndlvl commentedCompleted:
- with 'edit domain paths' permission
- with 'remove all domain paths' permission
Todo:
- without any domain path permissions
- with 'edit assigned domain paths' permission
Comment #11
grndlvl commentedTests the following permissions
- edit domain paths
- set domain access (does not have ability to set paths unless has domain path permission)
- remove all domain paths
- edit assigned domain paths
- publish to any assigned domains (does not have ability to set paths unless has domain path permission)
Comment #12
grndlvl commentedComment #13
agentrickardNo longer applies cleanly.
Comment #14
agentrickardI take that back. It does apply.
Comment #15
agentrickardComment #16
agentrickardOK, the tests won't complete for me. They just hang.
Comment #17
mably commented