Just a note that when Mime Mail is set to make all emails html ("Use mime mail for all messages" setting) it doesn't properly convert line endings to breaks (<br />) unless you apply the patch in post #7 here: http://drupal.org/node/1128354 (http://drupal.org/files/issues/mimemail_1128354_03.patch)

Comments

ezra-g’s picture

Title: Mime Mail patch » Mime Mail line breaks patch
Category: bug » task
Status: Fixed » Active

Thanks - marking this as active so that we can integrate it into Commons if it's not already been committed upstream.

ezra-g’s picture

Version: » 6.x-2.x-dev
Category: task » bug
Status: Active » Needs review
Issue tags: +Commons 2.7 radar

Marking as needs review and tagging for triage in Commons 2.7.
Reclassifying as a bug since that's the result for end-users.

ezra-g’s picture

Status: Needs review » Fixed

Looks good. This is committed. Thanks!

http://drupalcode.org/project/commons.git/commit/c27cfcc

ezra-g’s picture

Status: Fixed » Needs work

This patch breaks the Drush make build.

can't find file to patch at input line 5 [notice]
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/includes/mimemail.rules.inc b/includes/mimemail.rules.inc
|index 94ffc1b..56b3bba 100644
|--- a/includes/mimemail.rules.inc
|+++ b/includes/mimemail.rules.inc
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 29
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/mimemail.module b/mimemail.module
|index 5e18255..08f6a1b 100644
|--- a/mimemail.module
|+++ b/mimemail.module
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
Downloading project messaging to /tmp/drush_tmp_1338915651_4fce3b43742a2 ... [notice]
Downloading project link to /tmp/drush_tmp_1338915651_4fce3b4374707 ... [notice]
Unable to patch mimemail with mimemail_1128354_03.patch. [error]

ezra-g’s picture

This is reverted pending the patch to Mimemail being re-rolled. http://drupalcode.org/project/commons.git/commit/2c95418

ezra-g’s picture

Issue summary: View changes

escaping br tag