Closed (fixed)
Project:
Views Flag Refresh
Version:
7.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
10 Nov 2011 at 23:22 UTC
Updated:
20 Oct 2012 at 12:36 UTC
Jump to comment: Most recent file
The flag selection in the use ajax part of views is not exported when using standard view export or using features. Is it possible to add?
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 1338220-7-views-plugin.patch | 7.14 KB | rupl |
| #3 | views_flag_refresh_noscroll_export.patch | 8.15 KB | Eugene Fidelin |
Comments
Comment #1
bjalford commentedComment #2
Eugene Fidelin commentedThis bug is still exists. Seems module must be fully rewritten to be like views plugin.
Comment #3
Eugene Fidelin commentedI have fixed this bug.
I re-implement settings of this module as plugin for Views - in this case all settings are exported in standard way.
Also this patch contains new functionality described here http://drupal.org/node/1693130
Comment #4
papagrandeI tried the patch and while it functions, I get Invalid argument supplied for foreach() base.inc:83 when editing or viewing a View as well as when I clear caches.
Also, I'm not seeing the Flag selection being exported with view. When I run a diff on the feature with the exported view, it shows no changes being present.
Comment #5
Eugene Fidelin commentedCan you provide full text of error message. I need to know exact filepath
Comment #6
papagrande@Eugene Fidelin, I can't recreate the error right now as I've backed out the patch, but I'm pretty sure the path was sites/all/modules/contrib/views/includes/base.inc.
Comment #7
ruplPatch in #3 was rolled against a packaged release, I'm presuming beta1 based on the diff.
Here is a re-roll of the patch against latest dev with the following improvements:
I developed this on a View which already had the old form settings toggled, so I can confirm that there is no update hook necessary for current users.
The only remaining task is to make sure that views_flag_refresh is declared as a dependency in the Feature's .info file.
Comment #8
Eugene Fidelin commentedImplemented
Comment #9
Eugene Fidelin commented