Just installed this module.
- Module version: 6.x-1.x-dev
- System version: Drupal 6.22
- PHP version: 5.3

After setting the mail server info and the mail server credential of a user (UID=1), the "E-mail" link in the Navigation menu has gone.

Also, this may not be related to the issue I am reporting, but I am wondering if we need a if statement in the hook_menu() implementation at line 59. No matter what uid a user has, the menu items should be registered by hook_menu() in the menu_router table, aren't they?

CommentFileSizeAuthor
#2 basic_webmail_1338368_hook_menu.patch4.7 KBhefox

Comments

aiwata55’s picture

I did further experimentation with the module, and I found the followings:

- the path "basic_webmail" returns WSOD, if the mail server credential is set for the current user.
- Clearing all cache removes the menu items such as "basic_webmail".
- Clearing all cache also removes the e-mail credential form on the profile edit page.

I wonder if this is just for me.

hefox’s picture

Status: Active » Needs review
StatusFileSize
new4.7 KB

This patch purely addresses the fact that basic_email_menu references the global $user object and conditionally defines menu entries based on not being anon.

oadaeh’s picture

Status: Needs review » Fixed

I've committed the patch. Thanks @hefox. The change is here: http://drupalcode.org/project/basic_webmail.git/commit/e7dbf92.

@aiwata55, check it and let me know if that fixes the other issues. There are more patches to come, so you might want to wait until I'm done.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

typo correction.
kid -> uid