Although D7 long ago dropped the ability in the default profile for users to register without admin approval, Commerce Kickstart still has this somehow.

This is a huge pain for new sitebuilders, because they innocently build a site and deploy it, and then find that a thousand spammers have created accounts (and perhaps content) without any approval.

I sure recommend that we go with what D7's default profile has.

rfay_dell_Selection_103.png

CommentFileSizeAuthor
#4 commerce_kickstart.admin_approval_1339274_04.patch634 bytesrfay
#3 defaultuserregistration-1339274-3b.patch645 bytesjoshmiller
rfay_dell_Selection_103.png29.59 KBrfay

Comments

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
Status: Active » Needs review

In the standard minimal install profile, this line does it:


  // Allow visitor account creation, but with administrative approval.
  variable_set('user_register', USER_REGISTER_VISITORS_ADMINISTRATIVE_APPROVAL);

However, I'm not familiar enough with git to produce a patch. I know, I need to get over this, and I'm sure there's plenty of documentation pages to get me started. I think I'll go to the next Drupal meetup in Indianapolis and have one of the coders set git up for me on the mac laptop so I can play.

Josh

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Active

Thanks for studying this, @joshmiller - Please provide a patch to set to "Needs review" though.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
StatusFileSize
new defaultuserregistration-1339274-3b.patch645 bytes

Attached is a patch of comment #1.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Needs review
StatusFileSize
new commerce_kickstart.admin_approval_1339274_04.patch634 bytes

That doesn't remove the existing setting (the root of the problem). I think this one will do it.

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Hmm, must've been changed late in the game for Drupal 7, as we were tracking the standard profile for quite a while. : ?

Didn't see this before rolling the rc6, but it'll be in the next point release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

scott859’s picture

scott859 commented
Issue summary: View changes

Greetings,

I know this is an old issue but I have a question on this:

If this is set up as: Visitors, but administrative approval is required - does the system automatically create and approve an account for a customer that has completed an order? Or does admin need to approve customer order created user accounts as well?

Thanks for any insight you can give me on this.

armyofda12mnkeys’s picture

armyofda12mnkeys commented

Scott859, ever find out answer to your question?

scott859’s picture

scott859 commented

@ armyofda12mnkeys

What I found was that if it is set up as Visitors, but administrative approval is required - the system automatically creates and approves an account for that customer when they have completed the checkout.