[D6] Authored Blog

Hi and thanks for your contribution!

Automated review (Please keep in mind that this is primarily a high level check that does not replace but, after all, eases the review process. There is no guarantee that no other issues could show up in a more in-depth manual follow-up review.)

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards):
  

  Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
  
  sites/all/modules/pareview_temp/test_candidate/authored_blog.module:
   +26: [normal] Menu item titles and descriptions should NOT be enclosed within t().
   +29: [normal] Menu item titles and descriptions should NOT be enclosed within t().
   +29: [critical] The value for the 'access callback' must always be a string which is the the name of the function - never a function call. It may also be assigned the value TRUE or FALSE if the callback is always (or never) accessible.
   +223: [minor] There should be no trailing spaces
  
  Status Messages:
   Coder found 1 projects, 1 files, 1 critical warnings, 2 normal warnings, 1 minor warnings, 0 warnings were flagged to be ignored
  

• README.txt is missing, see the guidelines for in-project documentation.
• @file doc block is missing in the module file, see http://drupal.org/node/1354#files .
• @file doc block is missing in the install file, see http://drupal.org/node/1354#files .
• Comments: there should be a space after "//", see http://drupal.org/node/1354#inline
  

  authored_blog.module:387:  //drupal_set_message('<pre>'.print_r($changed_elements,true)."</pre>");
  

• ./authored_blog.module: comment lines should break at 80 characters, see http://drupal.org/node/1354#general
  

    // Pull the correct action out of form_state if it's there to avoid AHAH+Validation action-rewrite.
      // Pull the correct action out of form_state if it's there to avoid AHAH+Validation action-rewrite.
  

• Comments should be on a separate line before the code line, see http://drupal.org/node/1354#inline
  

  ./authored_blog.module:52:  $form ['#cache'] = TRUE; // Make sure the form is cached.
  ./authored_blog.module:182:    $form ['#cache'] = TRUE; // Make sure the form is cached.
  ./authored_blog.module:389:  drupal_json(array('status' => FALSE, 'data' => theme('status_messages') . drupal_render($changed_elements), // rebuild just the part that needs to be changed
  

• ./authored_blog.install: all functions should have doxygen doc blocks, see http://drupal.org/node/1354#functions
  

  
  function authored_blog_install() {
  --
  
  function authored_blog_uninstall() {
  

• ./authored_blog.module: all functions should have doxygen doc blocks, see http://drupal.org/node/1354#functions
  

  
  function authored_blog_perm() {
  --
  
  function authored_blog_init() {
  --
  
  function authored_blog_menu() {
  --
  
  function authored_blog_admin_form(&$form_state) {
  --
  
  function authored_blog_admin_form_validate($form, &$form_state) {
  --
  
  function authored_blog_admin_form_submit($form, &$form_state) {
  --
  
  function get_user_refernce($type) {
  --
  
  function blogs_user_reference_callback() {
  --
  
  function _authored_blog_skip_validation(&$form) {
  --
  
  function authored_blog_form_alter(&$form, $form_state, $form_id) {
  --
  
  function authored_blog_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {
  --
  
  function authored_blog_theme() {
  --
  
  function theme_authored_blog_blog($blogs_fields) {
  --
  
  function get_blogs_entry_rel_blogs($bid, $uid) {
  --
  
  function _get_blogs($uid) {
  --
  
  function _get_users_list() {
  --
  
  function authored_blog_insert_db($node) {
  --
  
  function blogs_select_lists() {
  --
  
  function authored_blog_ahah_submit($form, &$form_state) {
  --
  
  function authored_blog_form_alter_callback() {
  

• ./authored_blog.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function get_user_refernce($type) {
  function blogs_user_reference_callback() {
  function get_blogs_entry_rel_blogs($bid, $uid) {
  function _get_blogs($uid) {
  function _get_users_list() {
  function blogs_select_lists() {
  

• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  ./authored_blog.info:    ASCII text, with CRLF line terminators
  authored_blog.info
  authored_blog.install
  

• Assignments should have a space before and after the operator, see http://drupal.org/node/318#operators
  

  ./authored_blog.module:105:                    ON content_node_field.field_name=content_node_field_instance.field_name
  

• Remove all old CVS $Id tags, they are not needed anymore.
  

  authored_blog.install:3:// $Id$
  

• Do not use t() in hook_schema(), this will only generate overhead for translators.
  

    'description' => t('The base table for nodes.'),
      'description' => t('The primary identifier for a node type.'),
      'description' => t('Users uid'),
      'description' => t('The {node_type} of this node.'),
      'description' => t('The primary identifier for a node.'),
      'description' => t('The {node_type} of this node.'),
      'description' => t('The primary identifier for a node.'),
  

• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./authored_blog.install ./authored_blog.js ./authored_blog.info
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Manual review:

• authored_blog.module:387: Looks like a debug message? Please remove it.
• Before going into a deeper analysis I must confess that I did not yet really get either the problem you want to solve or how your module does this. Please don't feel harassed, but probably some more words for a clarification wouldn't be a bad idea :)

hth, dave

@asghar has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact