$view->pre_execute() is badly named [#1339388]

If you look at vew::pre_execute you see that it executes hook_views_pre_view and not something before executing the query.
Maybe it should be documented that this is runned before building something.

Comments

Comment #1

merlinofchaos commented 12 November 2011 at 17:08

I agree. That phase came in at the last minute when I discovered that I had set up paging information wrong. It should be pre_build(). It was named because it was supposed to be prior to 'execute_display' but time and history have compounded the error.

We could rename it pre_build() and hten provide pre_execute() as a deprecated pointer to pre_build() with an explanation. That would preserve the API but bring it inline with the correct naming attributes.