Closed (fixed)
Project:
Favicon
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Nov 2011 at 18:49 UTC
Updated:
7 Aug 2013 at 01:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
mannos commentedThe favicon.ico is in the 'misc' folder by default; add that to your path and you'll see it. To add your own, try 'shortcut icon settings' on the settings page for your theme.
Comment #2
defigo commentedI have had this issue for a while and found that if you changed the name of the ico file and then assign the path in your settings it does work
For example I changed favicon.ico to example.ico
Comment #3
kbobash commentedBingo! Thank you @defigo, this is the only thing that worked for me...seems like a bug to me!
My setup is D7.16, multi-site, IIS 7.5, MS-SQL Server database
BTW, the path to my favicon is in the /sites/my-site-name/files folder
I used the file upload UI in the theme's settings page, but until I changed the name from favicon.ico to favicon2.ico, it still couldn't find the favicon!
When I had the favicon set to be favicon.ico, I looked in the variable table in the database for my theme's settings, and it had a null string for the path. After changing the theme's settings and uploading the favicon2.ico file, the variable was then set to "public://favicon2.ico".
Comment #4
johnennew commentedThis module should use the misc/favicon.ico file if nothing else is set. Patch attached.
This fixes some coding standards and tests as well.
Comment #5
johnennew commentedCommitted to 7.x-1.x branch
Comment #7
jwilson3The patch that was committed here doesn't do enough to work when you have placed a favicon.ico in your theme without using the Theme UI to upload a file (or specified the path to the favicon file).
Drupal core is smart enough to test whether the favicon.ico file exists in a theme when toggle_favicon = 1 and default_favicon = 1, but it specifically does not set the favicon_path variable. it only sets a 'favicon' variable instead, and this module needs to be doing the same.
I'm going to open a follow-up issue for this.