This is 6.x only:

There is a little mixup in activity_log/views/activity_log_views_handler_argument_owner_id.inc. It is checked against is_oneway = 0, but it should be either <> 0 or = 1.

-        WHERE (ur.requester_id = %d OR ur.requestee_id = %d) AND (ur.approved = 1 OR urt.is_oneway = 0)
+        WHERE (ur.requester_id = %d OR ur.requestee_id = %d) AND (ur.approved = 1 OR urt.is_oneway = 1)

Patch follows.

CommentFileSizeAuthor
#1 fix-is-oneway-check-1340600-1.patch1.24 KBfabianx

Comments

fabianx’s picture

fabianx commented
Status: Active » Needs review
StatusFileSize
new fix-is-oneway-check-1340600-1.patch1.24 KB

Add patch

icecreamyou’s picture

icecreamyou commented
Status: Needs review » Needs work

I think you're right, but I'd like to get someone else to test this before I commit it. I remember staring at that line for a long time because it looked like it wouldn't work to me but I basically copied it straight out of UR... but when I went back and looked at UR just now I could only find a partially negated version so I may have just copied it wrong.

Marking "needs work" because you missed a spot: line 771 in activity_log.entity_groups.inc has the same alleged problem.