Just confirming that this seems to not work with D7.9.
Following the setup @ http://skinr.org/how-it-works-7-steps on a fresh install gives me access to the admin components of skinr, but doesn't appear to pick up the predefined skins in theme folders.
Just to add, I have thought to check that this is actually an issue with D7.9 - so I did a clean install on a 7.8 version of Drupal and the walkthrough steps at skinr.org still fail to produce any results.
Apologies if this has hijacked a valid upgrade issue! I'll happily create a new issue if they turn out to be unrelated.
Are the "predefined skins" you mention above contained in a contributed theme or ones you created?
Because I've worked with Skinr and have created skins, when I saw this issue I was curious to see if there was a problem with version 7.9 of Drupal. I just did a clean install of Drupal 7.9 and the latest dev version of Skinr. Using my theme, Coolness, which contains Skinr skins, I cannot find any problems. The skins appear in the Skinr UI and can be applied to the relevant elements.
Perhaps you should test this with one of the Fusion-based sub-themes or even my theme to see if you still have any problems.
What I did was just follow the steps on the skinr.org site to test if it worked, as that is written on the project page as the docs for D7.
When it didn't work for 7.9, I then tried a fresh 7.8 - still no worky. So I guess (nay know!) it's something I'm doing in the setup, but I generally can't go wrong with following the instructions on the site.
The theme I'm using is my own Jalapeno, and the required couple of lines were added to the theme info file as per the walkthrough.
Yeah, it's not baked in on the D.O version yet. That was part of the reason for me doing this, as I was thinking of adding Skinr support to various aspects of the theme.
Should the skinr.org instructions work as is? If they are correct then I'm obviously doing something else wrong in the setup.
AHA! I just compared what's on the skinr.org site with other working versions.
The problem was a typo in the function name function mytheme_skinr_skin_styles_info(), I had an S on the 'skin', I could have sworn I'd just copied and pasted... but at least it's working now and my part can just be ignored :D
I had the same problem tonight when I upgraded from Drupal 7.9 to 7.10. I'm using the Mix and Match theme and suddenly there was no color option or much of anything else beside the "Advanced" tab. I fixed it by uninstalling Skinr and re-installing it.
I don't have much to go on here. @dreamleaf's problem seems to have been user error.
@ericwisconsin, if you have some additional details to offer (such as error messages, etc.), feel free to re-set the issue as active.
Comments
Comment #1
dreamleafJust confirming that this seems to not work with D7.9.
Following the setup @ http://skinr.org/how-it-works-7-steps on a fresh install gives me access to the admin components of skinr, but doesn't appear to pick up the predefined skins in theme folders.
Hope it's not too big a fix that's needed!
Comment #2
dreamleafJust to add, I have thought to check that this is actually an issue with D7.9 - so I did a clean install on a 7.8 version of Drupal and the walkthrough steps at skinr.org still fail to produce any results.
Apologies if this has hijacked a valid upgrade issue! I'll happily create a new issue if they turn out to be unrelated.
Comment #3
mjohnq3 commented@dreamleaf
Are the "predefined skins" you mention above contained in a contributed theme or ones you created?
Because I've worked with Skinr and have created skins, when I saw this issue I was curious to see if there was a problem with version 7.9 of Drupal. I just did a clean install of Drupal 7.9 and the latest dev version of Skinr. Using my theme, Coolness, which contains Skinr skins, I cannot find any problems. The skins appear in the Skinr UI and can be applied to the relevant elements.
Perhaps you should test this with one of the Fusion-based sub-themes or even my theme to see if you still have any problems.
Comment #4
dreamleafWhat I did was just follow the steps on the skinr.org site to test if it worked, as that is written on the project page as the docs for D7.
When it didn't work for 7.9, I then tried a fresh 7.8 - still no worky. So I guess (nay know!) it's something I'm doing in the setup, but I generally can't go wrong with following the instructions on the site.
The theme I'm using is my own Jalapeno, and the required couple of lines were added to the theme info file as per the walkthrough.
Comment #5
moonray commentedI looked at the the repo for Jalapeno, but didn't see any Skinr related info. Is this only local?
Comment #6
dreamleafYeah, it's not baked in on the D.O version yet. That was part of the reason for me doing this, as I was thinking of adding Skinr support to various aspects of the theme.
Should the skinr.org instructions work as is? If they are correct then I'm obviously doing something else wrong in the setup.
Comment #7
dreamleafAHA! I just compared what's on the skinr.org site with other working versions.
The problem was a typo in the function name function mytheme_skinr_skin_styles_info(), I had an S on the 'skin', I could have sworn I'd just copied and pasted... but at least it's working now and my part can just be ignored :D
Thanks all.
Comment #8
ericinwisconsin commentedI had the same problem tonight when I upgraded from Drupal 7.9 to 7.10. I'm using the Mix and Match theme and suddenly there was no color option or much of anything else beside the "Advanced" tab. I fixed it by uninstalling Skinr and re-installing it.
Comment #9
moonray commentedI don't have much to go on here. @dreamleaf's problem seems to have been user error.
@ericwisconsin, if you have some additional details to offer (such as error messages, etc.), feel free to re-set the issue as active.
Note: there have been issues reported in D7 version of Skinr where the theme has been disabled after an update. This was prevalent in D6 version of Skinr; see #943782: _system_theme_data() causes PHP notices, but system_theme_data() causes themes to be disabled on update.
Comment #10
moonray commentedClosing due to lack of new info.