With the Comium browser it is not possible to insert images.

This error occurs when inserting into comments and terms.

Reason:

// Add the click handler to the insert button.
$('.insert-button', context).unbind('click').click(insert);

 
This code works with Cromium:

// Add the click handler to the insert button.
$('.insert-button', context).click(insert);

 

Postscript

Curently it is not possible to insert images of comments and terms! Way out: Fix the limit of insertion of images only with nodes.

CommentFileSizeAuthor
#7 insert_double_fix.patch766 bytesquicksketch
#2 cromium-insert.js_.patch508 bytesquiptime

Comments

quiptime’s picture

quiptime commented

Sorry for the double post.

quiptime’s picture

quiptime commented
Status: Active » Patch (to be ported)
StatusFileSize
new cromium-insert.js_.patch508 bytes

With the patch it is possible to work with the Cromium browser to insert images on comments and terms.

Note
To test the patch are required the use of Patch - allow insert action on all textareas

quiptime’s picture

quiptime commented

bump

quicksketch’s picture

quicksketch
he/him
commented
Status: Patch (to be ported) » Reviewed & tested by the community

This patch looks fine to me. I'm not sure why we would be unbinding the click handlers first, as jQuery already prevents double binding of the same function. However, please stop bumping issues, I review my modules one at a time, it may take a few weeks for me to get to the Insert queue.

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Fixed

I can't reproduce this problem any more in newer versions of Chromium, but regardless it's not a bad idea. Committed to both branches.

quicksketch’s picture

quicksketch
he/him
commented
Status: Fixed » Needs work

This issue caused Insert to start inserting images twice on every click. Because the AJAX handler on fields attaches once when the field is added, and then again on the entire form, the click handlers end up getting bound twice.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs work » Fixed
StatusFileSize
new insert_double_fix.patch766 bytes

I've committed this patch which takes the classic approach of setting guard classes to prevent double-binding.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.