Comments

oskar_calvo’s picture

Any new about this request?

Oskar.

harshil.maradiya’s picture

josebc’s picture

Thank you for the module, however i don't think something like this should be done as independent of the original module, i think a patch adding this feature to Custom Tokens should do the job

harshil.maradiya’s picture

Thanks josebc,
I have committed as different patch , please review my patch

harshil.maradiya’s picture

Status: Active » Needs review
hanoii’s picture

  1. +++ b/token_custom.module
    @@ -281,4 +281,21 @@ function token_custom_delete_form($tkid) {
    +    'fe_custom_token_config' => array(
    

    Is this the standard naming conventions for features, or shouldn't this be namespaced with token_custom as a prefix?

  2. +++ b/token_custom.module
    @@ -281,4 +281,21 @@ function token_custom_delete_form($tkid) {
    +      'file' => drupal_get_path('module', 'custom_token') . '/custom_token_features.inc',
    

    I think this patch is missing the new file, if you are adding this with git, first add the files and then run git diff --cached, this will also include new/deleted files.

harshil.maradiya’s picture

oops my bad , apology for wrong patch
Let me change the status and i will update the patch with proper file

harshil.maradiya’s picture

Status: Needs review » Needs work
geek-merlin’s picture

Cool work!

harshil.maradiya’s picture

StatusFileSize
new6.57 KB

Hello hanoii,
I have fixed all comments please check and pass my patch

harshil.maradiya’s picture

Status: Needs work » Needs review
nidhi.badani’s picture

Assigned: Unassigned » nidhi.badani
nidhi.badani’s picture

Status: Needs review » Reviewed & tested by the community

Hi Harshil,

The patch works well!, I had created a custom token and then created a feature for it. On deleting it form the custom token list, I tried to restore it with features and yes it works as expected.

big_smile’s picture

The patch in #10 works perfectly for me. I hope it can be added to core!

Feature request: It would be nice if the patch could be updated to export "Custom Token Types" (at yoursite.com/admin/structure/token-custom/type).

Mouna Hammami’s picture

#10 works perfectly for me . Thanks!

fox_01’s picture

#10 works

anybody’s picture

Confirming RTBC!
What about a new release @maintainer?

Furthermore we need the same functionality for Drupal 8. So this has to be ported afterwards. Does someone have experience with features export in D8?

anybody’s picture

This is RTBC since 2 month now. Is there an active maintainer willing to create a new release?

mlima’s picture

Has this patch ever been released in the modules core? If not does the community allow a module fork in cases like that?

polynya’s picture

I became a maintainer recently when I worked on the port to Drupal 8. I haven't used the Drupal 7 version.

I can see a few issues with patch #10, one major and the rest minor. If someone can create a new patch then I'll test and merge it.

  1. Custom Tokens should not have a dependency on the Features module so the line should be removed from token_custom.info
  2. There looks like a typo in the name of a function - token_custom_features_config_get_tokend should be token_custom_features_config_get_tokens
  3. Fix this comment - "//here 11it is just a variable_get, in other cases, it could be a query!"
  4. Fix typo "Erroor"
  5. Remove 2 lines after "// with no further export processors called."
polynya’s picture

Status: Reviewed & tested by the community » Needs work
nikita_tt’s picture

StatusFileSize
new3.74 KB

Thanks, @harshil.maradiya for the patch (#10). I added some changes and corrected violations of coding standards.

Feature request: It would be nice if the patch could be updated to export "Custom Token Types" (at yoursite.com/admin/structure/token-custom/type).

You can use Strongarm to export "Custom Token Types".

perke’s picture

Version: 7.x-1.0-beta2 » 7.x-2.x-dev
Status: Needs work » Reviewed & tested by the community

Tested #22 on 7.x-2.0 and it works great, many thanks for the efforts. Moving to RTBC and latest 7.x dev

Anonymous’s picture

Yep, #22 works great on 7.x-2.0.
Please commit.

Thanks for the great module and patch!

Rafal Lukawiecki’s picture

Another vote to commit this patch, please. Has the maintainer left the project?

anybody’s picture

@Maintainer: This has been reviewed by many people, furthermore the integration will only add functionality and is not able to break existing functionality. Could this perhaps be committed?

It would really help a lot!

The points @polynya mentioned in #20 were fixed in #22.

Thank you in advance! Confirming RTBC++

  • polynya committed 1d97ad6 on 7.x-2.x authored by nikita_tt
    Issue #1341514 by harshil.maradiya, nikita_tt: Export custom tokens with...
polynya’s picture

Status: Reviewed & tested by the community » Fixed

This has been merged, over 9 years since the feature was requested!

anybody’s picture

Thank you very very much @polynya :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.