Inspired by the debugging in #1341144: CAS try to create the user more than one time, I think we should add a link in the error message "The CAS username is already in use on this site." The link should point at the user view or user edit page for the relevant other user.
For example, we could make the word "already in use" into the link:
The CAS username is already in use on this site.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 1341708-Add-link-to-user-in-error-7.patch | 6.18 KB | bfroehle |
| #5 | 1341708-Add-link-to-user-in-error-fixed.patch | 6.4 KB | bfroehle |
| #3 | 1341708-Add-link-to-user-in-error.patch | 5.88 KB | bfroehle |
Comments
Comment #1
metzlerd commentedI like this.... but perhaps it should be in the watchdog logs instead of in the user message? Do you recall whether we log this message? It would seem that the audience for this is the admin, and not the user trying to log in.
Comment #2
bfroehle commentedYes, of course it should only be in admin related settings. For example, reynierpm (in #1341144: CAS try to create the user more than one time) was trying to edit a user to add the CAS username and was getting the error. It would have then been easy to ask him if the link pointed to a valid user or not (indicating corruption in the {cas_user} table.
The relevant validation functions would be
and
Comment #3
bfroehle commentedCode for 6.x-3.x attached. In addition to providing a better error message I also unify three existing disparate cas_name #element_validate handlers.
Comment #5
bfroehle commentedFixed one little error -- missed a rename (_cas_user_register_cas_name_element_validate -> _cas_name_element_validate) in cas.user.inc. Yay for automated testing!
This should be ready to go.
Comment #7
bfroehle commented#5: 1341708-Add-link-to-user-in-error-fixed.patch queued for re-testing.
Comment #8
bfroehle commentedAnd a 7.x-1.x version... (not manually tested yet).
Comment #9
bfroehle commentedCommitted to 6.x-3.x and 7.x-1.x.