Change the order of buttons on Access rules for _role_ page

Ah, we didn't spec this out definitively in http://xjm.drupalgardens.com/blog/tac-mockups. I wonder if it would be best to have a "Delete selected" button under each group, and "Save all" by itself at the bottom of the form; or if there should only be one "Delete all selected" button?

I think having the delete button as close as possible to the selections to be deleted is good. But the same is also true for save. I don't know that you need them for each group any more than the save should need to be repeated for each group. But, as it stands now, even with the new interface, there is a lot of help text in between the form and the buttons. Moving the buttons above the help text would be beneficial. Save should probably be first, then delete. In most cases save is the desired option and having it first helps.

Repeating the buttons multiple times is overkill for roles where there may not be that many options. It also starts giving the impression that this is multiple forms and a delete/save would be required for each group, rather than the one save/delete working for the whole form. But just having the buttons inside (or immediately below) the "box" would be helpful. As it is, because of the size of the help text, it isn't immediately clear that the buttons are down there at the bottom until you get used to the form.

This is a complex interface, so I don't advocate getting rid of any of the help. I think it's useful. But switching the buttons and moving them up would be good.

Also, don't label it "delete all" ... keep the delete as "delete selected!"

Well, some of the help text is getting moved to the top of the form (where it makes a lot more sense) and other text will be inline. The details will live on the help page, which will be linked. Having it all the way at the bottom makes little sense.

Also, don't label it "delete all" ... keep the delete as "delete selected!"

Don't know what you're referring to here. Edit: Oh, that was just a typo. :)

Could you put a mock-up of what you are thinking in terms of help and other style changes on your drupalgardens site with a reference here to that mock-up?

Wherever the help text goes, IMO you don't want much separation between the items to be operated on (the rules in the box) and the action (save/delete). Having save/delete immediately follow is best, probably with save first. If each group becomes a separate form, then you would want to repeat the action for each form. In either case, don't repeat one action without the other. And don't say 'delete all' if you really mean 'delete selected.' Delete 'all' implies clearing ALL of the rules.

Edit: I personally find some of the help on the page to be useful. Like I said, it's a complex interface in terms of what you are trying to apply as rules, so the help on the form is helpful. Scrolling up and down is easier than looking at a separate page. If you do a separate page, I'd use a link that opens a new window.

It looks like this issue hasn't been looked at in a while. At a minimum, I think it would make sense to switch the order of the buttons at the bottom of the page. It isn't consistent with the rest of the Drupal UI to have the delete button before the more often used save button.