Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.When the module is installed, no node has additional meta information in the opengraph_meta tag. The fallback image is loaded very early in get_og_tag_defaults() and it is not overwritten by load_node_data() when there is no row. Later on, in render_data(), the code is not able to detect that the fallback image should be overwritten by the image loaded from the node because it is unable to distinguish between images loaded from the opengraph_meta row and the default image. This problem exists both in 6.x and 7.x.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1341900-fallback-image-d6-2.patch | 3.3 KB | Jorrit |
| #1 | 1341900-fallback-image-d6.patch | 3.08 KB | Jorrit |
| #1 | 1341900-fallback-image-d7.patch | 3.06 KB | Jorrit |
Comments
Comment #1
Jorrit commentedI have moved the call to retrieve the fallback image to a point where it is executed at a later point in the page load cycle. The patches for D7 and D6 are similar. I have uploaded two patches, but I think it is possible to apply the D7 patch and merge it to the D6 branch. I have also included a test that fails when the common.inc file is not patched.
Comment #2
sixelats commentedpatching 6.x-1.5 with d6.patch fails with:
patching 6.x-1.x-dev of 26 Nov 2011 with d6.patch results:
patching 6.x-1.5 with d7.patch results:
I've used the files from the last patching attempt mentioned above and they seem to work. Didn't try the patched dev version because the unpatched version gave me errors.
Comment #3
Jorrit commentedI'll try to reroll the patches later.
Comment #4
Jorrit commentedYou can apply the attached patch to 6.x-1.x-dev.
Comment #5
hiddentao commentedFixed in dev, for both 6.x and 7.x. Thanks for the patch.