Clicking the Next or Previous buttons should probably scroll the page up to the top. At the moment, if you have one page of the multipage form thats quite long, and the next page is very short, when you click the next button to go from the long page to the short page, you then have to scroll up to be able to see any of the form elements on the short page, as they are all right at the top.

CommentFileSizeAuthor
#20 field_group-multipage-scroll-to-top-1341996-pk-20.patch941 bytesprashant.kabade
#19 field_group-multipage-scroll-to-top-1341996-20_0.patch689 bytesprashant.kabade
#19 field_group-multipage-scroll-to-top-1341996-20_0.patch689 bytesprashant.kabade
#18 field_group-multipage-scroll-to-top-1341996-19.patch699 bytesnitesh sethia
#16 field_group-multipage-scroll-to-top-1341996-16.patch713 bytesnitesh sethia
#10 field_group-multipage-scroll-to-top-1341996-10.patch867 bytesjantoine
#7 field_group-multipage-scroll-to-top-1341996-7.patch853 bytesanniegreens
#6 field_group-multipage-scroll-to-top-1341996-6.patch2.92 KBanniegreens
#5 field_group-multipage-scroll-to-top-1341996-5.patch3.02 KBanniegreens
#1 1341996-multipage-scroll-to-top.patch904 bytesmrfelton

Comments

mrfelton’s picture

mrfelton commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new 1341996-multipage-scroll-to-top.patch904 bytes
bryancasler’s picture

bryancasler commented
Status: Needs review » Reviewed & tested by the community

Simple enough patch. Works as expected, just had to clear cache. Thanks for solving this mrfelton!

nils.destoop’s picture

nils.destoop commented
Status: Reviewed & tested by the community » Fixed

Changed the patch a bit. $('#page') is a bit hardcoded on theme. And a page group is not always on top of the page.
The window now pops to the multipage wrapper

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

anniegreens’s picture

anniegreens commented
StatusFileSize
new field_group-multipage-scroll-to-top-1341996-5.patch3.02 KB

Patch rerolled from #1 with the addition of whitespace removal.

anniegreens’s picture

anniegreens commented
StatusFileSize
new field_group-multipage-scroll-to-top-1341996-6.patch2.92 KB

Sorry. Environment specific pathing removed from patch.

anniegreens’s picture

anniegreens commented
StatusFileSize
new field_group-multipage-scroll-to-top-1341996-7.patch853 bytes

Re-rolled for latest dev using #page for those who want it. I'm still not convinced that the multipage group wrapper is the best solution, as it cuts off the top portion of the page that may be relevant.

kyleoliveira’s picture

kyleoliveira commented

The patch in #7 seems to work for me on simplytest.me. Is this not working for anyone? If not, any reason not to commit this?

katannshaw’s picture

katannshaw commented

@kyleoliveira:

FYI: Patch #7 worked great for me too. The only issue I had was when I also installed the Field Group Ajaxified Multipage module. For some reason, when you select the "Ajaxify" checkbox for a multipage group, the Next and Previous buttons don't scroll to the top. But if I un-select that checkbox, it works fine.

I'm guessing that if anyone has an issue at this point, it probably has something to do with that module, not the Field Group module with this patch on its own. I've created an issue report for that module with this information here: https://drupal.org/node/2111709.

jantoine’s picture

jantoine commented
Issue summary: View changes
Status: Closed (fixed) » Needs review
StatusFileSize
new field_group-multipage-scroll-to-top-1341996-10.patch867 bytes

Reroll of patch from #7. It seems that the issue was never reopened and comment #7 never addressed.

Status: Needs review » Needs work

The last submitted patch, 10: field_group-multipage-scroll-to-top-1341996-10.patch, failed testing.

Rob_Feature’s picture

Rob_Feature commented

I tried implementing the patch in #7 into version 7.x-1.5 and it fails....it looks like the .js never even fires. Maybe I'm missing something?

david.qdoscc’s picture

david.qdoscc commented

If the form is displaying in the administrative overlay, then then using #overlay-container rather than #page worked for me.

EDIT: but only in Edge browser - doh!

nitesh sethia’s picture

nitesh sethia commented
Status: Needs work » Needs review

#10 seems to be working for 7.x-1.5 version of the field_group module. We should plan to add this to the code as this would resolve the issue of scroll.

Thanks,
Nitesh Sethia

Status: Needs review » Needs work

The last submitted patch, 10: field_group-multipage-scroll-to-top-1341996-10.patch, failed testing. View results

nitesh sethia’s picture

nitesh sethia commented
Status: Needs work » Needs review
StatusFileSize
new field_group-multipage-scroll-to-top-1341996-16.patch713 bytes

We can remove the javascript code as it is not required.

Status: Needs review » Needs work

The last submitted patch, 16: field_group-multipage-scroll-to-top-1341996-16.patch, failed testing. View results

nitesh sethia’s picture

nitesh sethia commented
Status: Needs work » Needs review
StatusFileSize
new field_group-multipage-scroll-to-top-1341996-19.patch699 bytes

Rerolling the patch.

prashant.kabade’s picture

prashant.kabade commented
StatusFileSize
new field_group-multipage-scroll-to-top-1341996-20_0.patch689 bytes
new field_group-multipage-scroll-to-top-1341996-20_0.patch689 bytes

re-rolling patch for latest version 1.6 from #18

prashant.kabade’s picture

prashant.kabade commented
StatusFileSize
new field_group-multipage-scroll-to-top-1341996-pk-20.patch941 bytes

#19 is not working . Adding new

nils.destoop’s picture

nils.destoop commented
Status: Needs review » Closed (won't fix)