In IE7, this throws up

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0)
Timestamp: Tue, 8 Nov 2011 13:59:18 UTC


Message: Unexpected call to method or property access.
Line: 16
Char: 56222
Code: 0
URI: http://test.local/sites/all/modules/contrib/jquery_update/replace/jquery/jquery.min.js?v=1.5.2

Problem seems to be in line 135 of multipage.js:

this.nextLink.append('<span id="active-multipage-control" class="element-invisible">' + Drupal.t('(active page)') + '</span>');
CommentFileSizeAuthor
#12 1342006_12.patch630 byteskmcculloch
#11 1342006_11.patch814 byteskmcculloch
#10 1342006.10-multipage-js-error-in-ie.patch629 bytesmrfelton
#2 1342006-multipage-js-error-in-ie.patch950 bytesmrfelton
#1 1167808-multipage-js-error-in-ie.patch950 bytesmrfelton

Comments

mrfelton’s picture

mrfelton commented
Status: Active » Needs review
StatusFileSize
new 1167808-multipage-js-error-in-ie.patch950 bytes

This is not a fix, but a workaround as I need it working right now. Commenting out the line seems to have no adverse affect. The line is somefor screen readers, which I'm not bothered about right now. Patch attached so I can include in drush make.

mrfelton’s picture

mrfelton commented
StatusFileSize
new 1342006-multipage-js-error-in-ie.patch950 bytes

Here's a patch with a filename that matches the issue number so that my drush make file is self documenting.

jjchinquist’s picture

jjchinquist
Location Vienna, Austria
commented

I confirm that the patch works! We are testing why .append is not working (IE7 and IE8) - can anyone else confirm:
is the object that the .append is trying to change empty or a non-object?
is the function .append a bug in IE8?

jjchinquist’s picture

jjchinquist
Location Vienna, Austria
commented

I tested the patch, and added one more line:
console.log(this.nextLink);

At any time when I access "this.nextLink". IE 7 and 8 has a problem and javascript throws an error.

Hope it helps.

nils.destoop’s picture

nils.destoop commented
Status: Needs review » Fixed

The js has been changed for IE. Append is not possible on buttons.

jjchinquist’s picture

jjchinquist
Location Vienna, Austria
commented

I understand that, but IE8 and 7 seem to have a problem not only with the "append" function, but also with accessing the object this.nextLink (see my previous comment).

The module does seem to function correctly when the append function call is removed entirely. Can you test and commit? Is there a reason to include the function call?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

aaki’s picture

aaki commented
Status: Closed (fixed) » Active

This is far away from being fixed.

eadi’s picture

eadi commented

Confirming this bug beeing still active for IE7+8

mrfelton’s picture

mrfelton commented
Status: Active » Needs work
StatusFileSize
new 1342006.10-multipage-js-error-in-ie.patch629 bytes

I know this isn't a good patch, but we still need it, so here it is, again, against the latest codebase/

kmcculloch’s picture

kmcculloch commented
Issue summary: View changes
StatusFileSize
new 1342006_11.patch814 bytes

Another roll of the 'just comment out the offending line' patch, to address change from nextLink.after() to nextLink.append() in the offending line. (This line still causes a js crash in IE8.)

kmcculloch’s picture

kmcculloch commented
StatusFileSize
new 1342006_12.patch630 bytes

Correcting above patch to remove directory paths specific to my system

gambry’s picture

gambry
Primary language Italian
Location Milan
commented

I confirm the bug on IE8 (not sure about IE7), any chance to have the patch or any fix on next release (or soon on -dev) ?

nils.destoop’s picture

nils.destoop commented

gambry can you review if this patch fixes your problem. I'll commit it then.

nils.destoop’s picture

nils.destoop commented
Status: Needs work » Needs review
nils.destoop’s picture

nils.destoop commented
Status: Needs review » Needs work

Just saw the patch. Commenting it out is not a fix :D

nils.destoop’s picture

nils.destoop commented
Status: Needs work » Fixed

This is an issue that's already fixed in dev. The code that is in latest patch was already replaced.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 1: 1167808-multipage-js-error-in-ie.patch, failed testing.

The last submitted patch, 2: 1342006-multipage-js-error-in-ie.patch, failed testing.

The last submitted patch, 10: 1342006.10-multipage-js-error-in-ie.patch, failed testing.

The last submitted patch, 11: 1342006_11.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 12: 1342006_12.patch, failed testing.

nils.destoop’s picture

nils.destoop commented
Status: Needs work » Closed (fixed)