If the "Display/Hide WYMeditor" link is clicked to disable the WYMEditor and then re-enabled by clicking again the buttons for the editor stop working (eg bolding text no longer works). Tested on FF on MacOSX.

CommentFileSizeAuthor
#5 wymeditor-fix-bold-italics.patch2.18 KBMoxide
#1 wymeditor-fix-displayhide.patch831 bytesMoxide

Comments

Moxide’s picture

Moxide commented
Status: Active » Needs review
StatusFileSize
new wymeditor-fix-displayhide.patch831 bytes

It seems to be a problem with Gecko 'forgetting' the styleWithCSS command when hiding the iframe.
Could you please try the attached patch ?

kiz_0987’s picture

kiz_0987 commented
Status: Needs review » Needs work

Thanks. This patch definitely helps -- now the buttons will style the text again when the WYMEditor is re-displayed. However, when changing the text style (eg bold->italic) after re-displaying the WYMEditor it sometimes messes up the styling and adds in the html code elements instead (ie you start to see <em></em> in the styled text) which then get converted.

Moxide’s picture

Moxide commented
Status: Needs work » Active

I think I am seeking the wrong path...
Could you confirm that the same behaviour occurs when simply using 'Preview' :
1. Add new page
2. Add some text, make some parts bold and italics.
3. Click on Preview
4. Try and remove bold and italics

kiz_0987’s picture

kiz_0987 commented

Yes, the same behaviour does occur (with the unpatched version). I did not test the patched version -- should I?

Moxide’s picture

Moxide commented
StatusFileSize
new wymeditor-fix-bold-italics.patch2.18 KB

Here is a new patch, which includes the previous one.
There seems to be a problem with the way WYMeditor handles bold and italics (in Mozilla only)...

kiz_0987’s picture

kiz_0987 commented
Status: Active » Reviewed & tested by the community

Seems to work fine. Thanks for your help.

Moxide’s picture

Moxide commented
Status: Reviewed & tested by the community » Fixed

Committed.

Thank you !

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Fixed » Closed (fixed)