Closed (fixed)
Project:
HotBlocks
Version:
6.x-1.6
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Nov 2011 at 21:05 UTC
Updated:
30 Nov 2011 at 00:01 UTC
Thickbox, used by HotBlocks, has a css global reset at the top of thickbox.css.
*{padding: 0; margin: 0;}
This is an antiquated method and a PITA to impose on your whole site, especially after the effort to use smart css normalization.
Having never found how it was “needed for thickbox”, and since this can’t simply be overridden, and since thickbox is discontinued, so there won’t be newer versions overriding the existing copy, I suggest removing this css global reset. I have commented this out using the promo module, for many projects.
Here’s a patch that simply removes the css global reset from thickbox.css.
| Comment | File | Size | Author |
|---|---|---|---|
| no-thickbox-css-global-reset.patch | 905 bytes | echoz |
Comments
Comment #1
justindodge commentedWell, it certainly is not needed by me.
Fix is committed to dev.
Comment #2
echoz commented