In some cases domain_prefix module has tried to include "domain_prefix.admin.inc" file more than one time.

CommentFileSizeAuthor
#3 domain_prefix-include-1343352-3.patch513 bytesgdud
#1 domain_prefix-include_problem-1343352-1.patch773 bytesbartoll
#1 domain_prefix-include_problem-1343352-1.txt412 bytesbartoll

Comments

bartoll’s picture

bartoll commented
Status: Active » Fixed
StatusFileSize
new domain_prefix-include_problem-1343352-1.txt412 bytes
new domain_prefix-include_problem-1343352-1.patch773 bytes

Here is fix this bug

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Fixed » Needs work

@bartoll

Issues can only be marked fixed if the code has been tested and committed.

Please describe what "cases" trigger this problem. I have never seen it before and don't have time to chase it down.

The correct fix is actually to use module_load_include().

http://api.drupal.org/api/drupal/includes--module.inc/function/module_lo...

gdud’s picture

gdud commented
StatusFileSize
new domain_prefix-include-1343352-3.patch513 bytes

I met this problem during simpletest run.

Using module_load_include() is better solution of course.

I attached new patch which was produced by 'git diff' command.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs work » Needs review

Thanks.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Project: Domain » Domain Prefix
Version: 6.x-2.13 »
Status: Needs review » Patch (to be ported)

Committed to 6.x. This needs to be applied in 7.x.