Using after and before advanced cycle options makes pager don't work

Works for me. Thanks

#1 works for me. Thanks!! This is definitely needed, can't use before/after functions and pager without it.

#1 works.

Did a new patch for latest version. Also removed forwardFlag from user before and and after functions as pager_after_fn(curr, next, opts) and pager_before_fn(curr, next, opts) do not have fourth parameter.

                 settings.opts[option] = function(currSlideElement, nextSlideElement, options, forwardFlag) {
-                  pager_after_fn(currSlideElement, nextSlideElement, options, forwardFlag);
+                  pager_after_fn(currSlideElement, nextSlideElement, options);
                   eval(afterValue);
                 }

                settings.opts[option] = function(currSlideElement, nextSlideElement, options, forwardFlag) {
-                  pager_before_fn(currSlideElement, nextSlideElement, options, forwardFlag);
+                  pager_before_fn(currSlideElement, nextSlideElement, options);
                  eval(beforeValue);
                }

Please fix this! Up since November 16, 2011! Took me some time to figure this out.

I can confirm that #4 works on latest dev. PLEASE push this, thank you.

I'll confirm #4 on the latest release again. Would be really nice to have this in at least the dev branch.

From what I can tell this patch breaks the active pager class being set on initial load and in autoplay. After applying the patch in #4 the active class is only set if I click on a pager item.

Here's a new patch that fixes a few things: it will now resize slides if needed (context was being lost) and if the before or after function doesn't exist, it will still work properly.

I can confirm the patch in #8 resolves the issue I was seeing with active pagers.

I have also used the patch and it works for me.

What doesn't work, though, is the "pauseOnPagerHover: 1"
I have set this through the views advanced options, and even tried 'hardcoding' it by setting it to 1 on jquery.cycle.all.js (line 1050).

Not sure if this is related, or if I should open a new issue?

After updating views_slideshow_cycle.js as in solution #8, it works ok for me, but with side effects.

If I delete the custom "after" and "before" options (as specified in View->Slideshow->Settings->"jQuery Cycle Custom Options") from my View definition, or if I create a new View with Slideshow, the default Page Counter doesn't change when slide changes. But if those "before" and "after" options are specified in View definition then it's ok.

Patch at #8 works for me. I had the "active pager" problem with a "before" advanced setting. Didn't notice any drawbacks yet.

Thanks.

Thanks a lot to tunic, hkirsman, danlinn and everyone else for the great work on the patches, testing, reviews and reporting.

It's more time this got committed and I went ahead and had this rolled at:

7.x-3.x: d01c839.

Marking this as fixed.

Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyone for the help and great work on this issue.

Cheers!

Just a note for those who might be stuck on Drupal 6 and having this problem, since this probably won't get backported, you can add something like this to your "after" callback.

       var pagerId = '#' + 'views_slideshow_pager_field_item_bottom_[VIEW-NAME]-[DISPLAY-NAME]_' + opts.currSlide;
       if (!$(pagerId).hasClass('active')) {
          $('.views_slideshow_pager_field_item').removeClass('active');       
          $(pagerId).addClass('active');
       }

Not great - it will have a lag time where the slide shows then a second later the pager catches up, but better than being broken.

Also of course you can get the pagerId some more general way if you want this to apply to all slideshows.