Now that mimeparse is forked back into the d.o repository, do you want to commit my patch so mimeparse doesn't barf warnings on PHP 5.3?

http://code.google.com/p/mimeparse/issues/detail?id=13

Proper patch incoming as soon as I get the node id for this issue so I can make a proper git commit.

CommentFileSizeAuthor
#3 0001-1343516-by-mradcliffe.-mimeparse-split-deprecation-f.patch1.05 KBmradcliffe
#1 0001-1343516-by-mradcliffe.-mimeparse-uses-deprecated-spl.patch1.07 KBmradcliffe

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 0001-1343516-by-mradcliffe.-mimeparse-uses-deprecated-spl.patch1.07 KB

Here's my patch. This would also fix the test bot.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Reviewed & tested by the community

Looks good.

Did mime parse get put back in 6.x as well?

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 0001-1343516-by-mradcliffe.-mimeparse-split-deprecation-f.patch1.05 KB

Yes, it did in http://drupalcode.org/project/services.git/commit/5a5d5185565ad99520ec52....

I don't have a current 6.x copy of Services installed to test, but it's a minor change. There are probably more php 5.2 users on 6.x though.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Reviewed & tested by the community

They look good.

kylebrowning’s picture

kylebrowning commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.