Using the default Garland theme, the images in my gallery show the bullets from the LI tags.
I'm baffled as to how this happens, as the Firefox DOM inspector shows that they get a list-style-type: none; from garland/style.css (line 116), and the calculated CSS property is shown as none too.

Comments

drewish’s picture

if you look at the ordering of the css garland is listed last so it's settings will overwrite the module's. i'm not really sure it's a bug because it's working as designed. i don't know if adding a ! to the class would do the trick.

joachim’s picture

Status: Active » Needs review
StatusFileSize
new221 bytes

Found the problem.
The disc is NOT an HTML-provided disc -- the LIs have no list marker, as reported by firefox (I tried setting it to circle and saw a circle PLUS the offending discs). The disc is in fact an image provided for the menus to look funky: in garland's stylesheet:
background: transparent url(images/menu-leaf.gif) no-repeat 1px .35em;

The fix is to add
background: transparent;
to the ul.images li rule in image_gallery.css

Patch attached.

drewish’s picture

Status: Needs review » Fixed

dope. i've committed that to head and 5

joachim’s picture

Status: Fixed » Active

Not all themes use this method.
Bluebreeze theme is still showing bullets. It's non-core, but I gather it's popular and used as a basis for other themes too.
The fix for this is:

ul.images li {
list-style: none;
}

sun’s picture

Status: Active » Closed (fixed)

Image cannot support each and every theme in the wild. Reverting status.

joachim’s picture

Status: Closed (fixed) » Active

I don't think it's unreasonable to cater for themes that use bullet types. It's default HTML behaviour. This is only one line of CSS, so I don't think it kills us to have it.

sun’s picture

Status: Active » Needs review
sun’s picture

Version: 5.x-1.0 » 6.x-1.0-alpha4
Status: Needs review » Fixed
StatusFileSize
new539 bytes

Committed attached patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.