Views 7.x-3.0-rc3 is out and it would be great for NodeStream to implement it as soon as possible.

CommentFileSizeAuthor
#11 upgrade-to-views3rc3-1344354-11.patch2.65 KBpontus_nilsson
#10 upgrade-to-views3rc3-1344354-10.patch2.12 KBpontus_nilsson
#9 upgrade-to-views3rc3-export-1344354-8.patch25.46 KBfabsor
#8 upgrade-to-views3rc3-1344354-7.patch2.05 KBfabsor
#7 upgrade-to-views3rc3-1344354-6.patch1.35 KBfabsor
#5 reexport-views-rc3.patch12.9 KBpontus_nilsson
#6 nodestream-make-views-rc3.patch523 bytespontus_nilsson
#1 viewsrc3-1344354-1.patch477 bytespontus_nilsson

Comments

pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented
Title: Upgrade to Views rc-3 » Upgrade to Views 7.x-3.0-rc3
StatusFileSize
new viewsrc3-1344354-1.patch477 bytes

For starter, here is a patch for the make file that upgrades to rc3.

I will have more time to work on this tomorrow. Please comment if any thing else than the work stated below is needed / nice to have.

Action plan:
1. See that the patch #1247292: Displaying a view mode should be possible when using the node revision table specified in the makefile applies in rc3. Seems like we still need it?
2. Test out existing views if they work
3. Reexport all views?

pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented
Assigned: Unassigned » pontus_nilsson
fabsor’s picture

fabsor commented
Priority: Normal » Major

I really want this in, so I'm bumping the priority on this.

pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented

Updated action plan

Step 1

  1. Update Views to rc3 in make file
  2. Resave all Views
  3. Check features state, if overriden re-export features. After features export checkout strongarm.inc fields.inc and .info since we don't want features to export this.
  4. Make a diff just to be sure and manually check the result
  5. Create patch

Step 2

  1. Remove views patch
  2. Remove unwanted views for viewing references in node template. Use teaser here instead.
pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented
StatusFileSize
new reexport-views-rc3.patch12.9 KB

This is patch against ns_core that holds all views reexported. There are issues
1. #1346042: Incompability with Views rc 3
2. #1346072: Rexport of excisting Views using Views rc3 drops Reference dialogue settings

Other than this the reexport seems to have no bigger harm
node table has been replaced with views_entity_node
views api version has been changed from 3.0-alpha1 to 3.0

pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented
Status: Active » Needs review
StatusFileSize
new nodestream-make-views-rc3.patch523 bytes

Tiny patch against nodestream.make to upgrade to views rc3.

fabsor’s picture

fabsor commented
StatusFileSize
new upgrade-to-views3rc3-1344354-6.patch1.35 KB

We also need the latest version of references. Here is an updated patch against the NodeStream repository.

fabsor’s picture

fabsor commented
StatusFileSize
new upgrade-to-views3rc3-1344354-7.patch2.05 KB

Here is a patch with updated versions of references dialog and Cross Clone.

fabsor’s picture

fabsor commented
StatusFileSize
new upgrade-to-views3rc3-export-1344354-8.patch25.46 KB

Here is a new views export with the references dialog stuff included.

pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented
StatusFileSize
new upgrade-to-views3rc3-1344354-10.patch2.12 KB

Patch in 8 won't apply anymore (head has changed). New patch against nodestream.make

pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented
StatusFileSize
new upgrade-to-views3rc3-1344354-11.patch2.65 KB

Got loads of warnings on draggable views. New patch against nodestream.make with a later version of draggable views.

pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented
Status: Needs review » Reviewed & tested by the community

Ok, I've tried this patch out several times on both a fresh install of NodeStream and on an installation profile using NodeStream as base.
With patch from #11 everything seems fine to me.

pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented
Status: Reviewed & tested by the community » Fixed

Pushed against nodestream and ns_core.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Better desc.