Somehow I'm motivated, so here are a couple of more patches in the 7.x-3.x version after I noticed the test bot's status. This should fix the last PHP warning so the test bot should be happy.

The one question is, can we set the $endpoint->server_settings[$endpoint->server] to an empty array? Or does it need its values filled out on initial form submit? I don't think this should be speedily committed without a couple of people reviewing/testing it.

The second patch simply fixes a typo in services.module.

CommentFileSizeAuthor
#2 services-typo-fix-6.x.patch599 bytescotto
0002-Fix-typo.-authenication-should-be-authentication.patch857 bytesmradcliffe
0001-Fix-broken-test-by-setting-the-appropriate-server-se.patch1.31 KBmradcliffe

Comments

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Reviewed & tested by the community

these look good.

Do we need 6.x version for the second patch?

cotto’s picture

cotto commented
StatusFileSize
new services-typo-fix-6.x.patch599 bytes

Good catch. Here's a 6.x version.

kylebrowning’s picture

kylebrowning commented
Status: Reviewed & tested by the community » Closed (fixed)

Fixed thanks.