I'm working on a patch to allow users, through the UI, to choose between GET/POST/PUT/DELETE http methods. This is already available for developper, just not implemented in UI.
I need it on an important project at work, so I've worked on this patch and I commit it :
- add a "
" in the Operation setting UI
- make it available only on REST web services
- save it in $operation->type
It's my first patch on a project, so please tell me if I'm doing something wrong ;)
Comments
Comment #1
ncellier commentedAnd here is the patch.
I realize there is at least one more change to do : when a web service is changed from rest to soap, reset all the $operation->type values
Comment #2
klausiYay, good idea!
REST specific stuff should go into the wsclient_rest.module. Use hook_form_FORM_ID_alter() there.
there should be no trailing spaces.
Comment #3
farald commentedHow's the patching going on this? Somebody writing or shall I?
Comment #4
klausiThis looks inactive, so you are good to go. Just committed #1413344: incorporate formAlter() methods and random improvements , so that may help you.
Comment #5
farald commentedOk, Ill have a look into it.
Comment #6
ezeedub commentedThis is just what I was looking for. Nice module all!
I had some trouble applying the patch (2nd hunk failed). Here's a new one.
Now when I save an operation with HTTP Method "GET" (as well as the other methods), I get the following error:
I dont' have time atm to drill down further, but I thought this might be of use...
Comment #7
ezeedub commentedAnd here's the patch.
Comment #8
muffinzap commentedHi, last patch works great, but has a problem with the file paths. Patches must be generated from the module's folder.
Olso I made an Improvement for compilance with the services module, since the services module needs to get the post fields in the $data array, and not in the $parameters one.
Comment #9
klausiDoes not seem to be related to this issue?
This is a REST specific parameter, so it does not make sense for SOAP services or others. This should be added by wsclient_rest module.
Variables transmission method? Better use "Specify the HTTP request method used for this operation"?
Comment #10
PatchRanger commentedRe-rolled given #9.
Please note: the patch is git-aware (i.e., was made using
git format-patch), so it should be applied usinggit am. See https://drupal.org/node/1146430 for more details.Comment #11
klausiThis is still here, does not belong in the patch.
Comment #12
PatchRanger commentedRe-rolled given #11.
Comment #13
robloachComment #14
klausiCommitted, thanks! http://drupalcode.org/project/wsclient.git/commit/04df4ed