Make Drupal Core Coding Standards compliant

douggreen - April 7, 2007 - 19:38
Project:Drupal
Version:6.x-dev
Component:base system
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

The attached patch has 173 minor coding standard fixes found using the coder. Most changes are due to the string concatentation rules, but there are a few others. I tried to not modify more than was needed, but some double checking is definitely in order.

AttachmentSizeStatusTest resultOperations
core-style.patch68.33 KBIgnoredNoneNone

#1

chx - April 8, 2007 - 03:42
Status:needs review» reviewed & tested by the community

Drupal plumbing season!! Nice job man. Just reading the patch made me tired :P I caught a miniscule error, namely you included E_ALL ^ E_NOTICE inside the patch. Removed that, rerolled, RTBC'd. Nice Easter present. thankee!

AttachmentSizeStatusTest resultOperations
core-style_0.patch60.27 KBIgnoredNoneNone

#2

Dries - April 13, 2007 - 08:56
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks a bundle. :)

#3

Anonymous - April 27, 2007 - 09:01
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.