It appears QP is now bundled in this module, but README.txt (here) and the install notice both mention downloading? README is actually more contradictory, since there's a section about removing the bundled library right after the paragraph about needing to download it manually.

I'm happy to write a quick patch if a maintainer can verify I'm not missing something crazy obvious?

Comments

mbutcher’s picture

mbutcher commented

The history:

At one point, this required that you download QueryPath separately. People complained that installation was unnecessarily complex.

Since I am the author of both the library and the module, I can put both in the repo, so I did. Different people complained -- this time that I was bending the Drupal repo rules (which I'm not) and that this sort of situation should be handled by Libraries API.

At the moment, I have a branch that uses Libaries, and the main release branch that still includes QP.

Having tinkered with Libraries for a while, I'm still leaning toward leaving QP inside of the module.

If you want to contribute an update, I'll definitely apply. I need to update the module to use QueryPath 2.1.1, so this would be a great time to do it all.

Thomas_Zahreddin’s picture

Thomas_Zahreddin commented

my 2ct:
i'd prefere the libraries solution, since this reflects the nature of querypath better, and by now the checkout of of a folder from the repository should not be so hard any more:

https://git.wiki.kernel.org/index.php/GitFaq#How_do_I_clone_a_subdirecto...

(Thank you for this cool lib, i'll use it in combination with migrate)

mbutcher’s picture

mbutcher commented

I've been thinking about this a lot as QP3 is nearing alpha, so this was a great reminder to communicate what's in my head.

I will probably move to Composer support (http://getcomposer.org and http://drupal.org/project/composer), with Library support as a backup. Composer is emerging as the leader (PHP-wide) in dependency management solutions for libraries.

Given that git-subtree is looking poised to supersede git submodules, that is another good options for storing QueryPath inside of the module. I'll have to think about that. Given that the last three releases of QueryPath have not required any changes in the module, I'm thinking that for the sake or release independence I may opt for the composer/library route.