[D7] FreeGeoIP GeoIP [#1345158]

This module is a Drupal 7 module that uses the free web service FreeGeoIP.net to perform a country lookup on visitors and provide their country code as a template variable in themes.

It is different from the GeoIP API module in two important respects: it uses a web service, not a downloaded database file (and so does not require periodic updating) and it supports Drupal 7. In fact, it is only for D7 at the moment. An integration with GeoIP API is desired, and would require GeoIP API to support alternate lookup engines and be ported to D7.

Other planned improvements include context integration and administration settings for default IP on localhost machines.

Sandbox project is here: http://drupal.org/sandbox/ethanw/1345130, and the repo can be clones with
git clone --branch master git@git.drupal.org:sandbox/ethanw/1345130.git

Thanks!

Comments

Comment #1

chakrapani commented 18 November 2011 at 18:46

Status:

Needs review

» Needs work

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

Run coder to check your style, some issues were found (please check the Drupal coding standards):

Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards

sites/all/modules/pareview_temp/test_candidate/freegeoip_geoip.module:
 +3: [minor] @file description should be on the following line
 +36: [normal] missing space after comma

Status Messages:
 Coder found 1 projects, 1 files, 1 normal warnings, 1 minor warnings, 0 warnings were flagged to be ignored

README.txt is missing, see the guidelines for in-project documentation.
freegeoip_geoip.module in freegeoip_geoip.info: It's only necessary to declare files[] if they declare a class or interface.
All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
```
./freegeoip_geoip.module ./freegeoip_geoip.info
```

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Comment #2

ethanw commented 15 December 2011 at 06:00

Status:

Needs work

» Needs review

Thanks Chakrapani.

I've updated to address all coding standards issues reported by the DrupalCS tool, see http://ventral.org/pareview/httpgitdrupalorgsandboxethanw1345130git for the report based on the latest sandbox codebase. No errors are being reported.

I removed the unneeded files[] line in the info file (I think that was left over from Module Builder or a vim skeleton) and added a README.txt file.

Very helpful review, thanks again.