Closed (won't fix)
Project:
Category
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Apr 2007 at 22:30 UTC
Updated:
3 May 2009 at 22:10 UTC
Localizer needs db_rewrite_sql() to be applied to each query that fetches nodes from the database.
Attached patch simply adds db_rewrite_sql() to category_get_containers() and additionally fixes quotes in category_get_distant_child_containers().
Note: This patch does not completely implement Category support for Localizer. See http://drupal.org/node/122964 for information about complete implementation.
| Comment | File | Size | Author |
|---|---|---|---|
| category.inc_.patch | 1.69 KB | sun |
Comments
Comment #1
sun*bump*
Any chance to get this one in? It doesn't affect functionality of Category module. You can even leave out the cosmetic change in category_get_wrapper_status() if you want to.
Localizer v2.x is out now and I'd like to avoid unnecessary bug reports. So just push the magic button, please :)
Comment #2
sunbdragon? Anyone?
Comment #3
bdragon commentedUh, yeah. I'll get right on it. Sorry 'bout that.
--Brandon
Comment #4
bdragon commentedHmm, I don't like the idea of using db_rewrite_sql there.... I don't want to risk breaking stuff if someone turns on a node access module.
What other approaches do you think can be used here? What's not getting translated properly?
Comment #5
sunWithout this patch a user is able to add a child container/category to another container that is in a different language. If this happens, the added child is never displayed on a multilingual site. Category module uses db_rewrite_sql() in all other places. Because of that, Localizer and i18n are already able to filter categories by language. I don't see a problem and would rather consider it as a bug, if a user is able to add a child in a container that she is not allowed to access.
Comment #6
sun