Further to whichever kind soul introduced taxonomy_implode_tags and taxonomy_explode_tags, this patch:

  • Cleans taxonomy_node_save further by moving functional parts of the code into taxonomy_resolve_tags.
  • taxonomy_get_term_by_name now takes an additional $vid parameter that will allow searches to be limited to particular vocabularies. It is currently rather wasteful.
  • taxonomy_resolve_tags will prove useful in contrib as well.
  • Cleaner and lesser processing.

Additionally, taxonomy_implode_tags was buggy with a copy/paste error. Fixed in this patch as it is not possible to test otherwise.

-K

CommentFileSizeAuthor
#12 new_taxonomy.diff4.78 KBrobin monks
#8 new_taxonomy.diff4.78 KBrobin monks
#7 new_taxonomy.diff5.64 KBrobin monks
#5 streamline_save.patch4.83 KBbdragon
#3 tax-freetag_1.patch4.84 KBZen
#1 tax-freetag_0.patch4.67 KBZen
tax-freetag.patch5.07 KBZen

Comments

Zen’s picture

Zen commented
StatusFileSize
new tax-freetag_0.patch4.67 KB

Sync with HEAD. The taxonomy_implode_tags issue has been fixed elsewhere.

-K

dries’s picture

dries commented
Status: Needs review » Needs work

The PHPdoc code of the resolve function is not very descriptive.

Zen’s picture

Zen commented
Status: Needs work » Needs review
StatusFileSize
new tax-freetag_1.patch4.84 KB

better?

bdragon’s picture

bdragon commented
Status: Needs review » Needs work

Patch needs another reroll, two of the three hunks fail.

bdragon’s picture

bdragon commented
Status: Needs work » Needs review
StatusFileSize
new streamline_save.patch4.83 KB

Free reroll, courtesy of patch bingo.
Untested, visual inspection only.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Version: 6.x-dev » 7.x-dev

Unfortunately I think this is too late for D6...

robin monks’s picture

robin monks commented
StatusFileSize
new new_taxonomy.diff5.64 KB

Another free re-roll, compliments of patch bingo & friends ;-)

Changes:
- taxonomy_explode_tags is now drupal_explode_tags.
- This patch is tested.

Robin

robin monks’s picture

robin monks commented
StatusFileSize
new new_taxonomy.diff4.78 KB

Whoops, patch creep :)

Robin

Patch failed to apply. More information can be found at http://testing.drupal.org/node/13873. If you need help with creating patches please look at http://drupal.org/patch/create

Patch failed to apply. More information can be found at http://testing.drupal.org/node/13873. If you need help with creating patches please look at http://drupal.org/patch/create

Patch failed to apply. More information can be found at http://testing.drupal.org/node/13872. If you need help with creating patches please look at http://drupal.org/patch/create

robin monks’s picture

robin monks commented
StatusFileSize
new new_taxonomy.diff4.78 KB

The bot I created turns against me :(

Shame it had to be right :P

Robin

catch’s picture

catch
he/him
Primary language English
commented
Assigned: Zen » Unassigned
Status: Needs review » Needs work

This looks like a really nice cleanup, but it needs to be re-rolled for dbtng.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Closed (won't fix)

Terms are now handled through field.module, so I guess this can be marked as won't fix.

(Sorry for pinging the participants, I'm trying to clean up a few old
issues)