Triggers, Actions, and Workflow are tightly coupled concepts in Drupal, but for some reason they are scattered in 3 different menu trails.

"triggers": admin/structure/triggers
"actions": admin/config/system/actions
"workflow": admin/config/workflow
(and Rules: admin/config/workflow/rules)

To me, these are all clearly workflow-related items, and should all be located under the "workflow" menu path.

Filing as a usability bug against "user interface text" since it relates to a superficial change of multiple components.
I'm happy to roll a patch, maybe pending a usability review?

CommentFileSizeAuthor
#32 1345272-32.patch0 bytesbhaveshithape
#29 After-Patch-1345272-22.png42.86 KBManibharathi E R
#29 Before-Patch-1345272-22.png27.05 KBManibharathi E R
#28 AfterPatch.png18.16 KBsaman malik
#28 Before Patch..png46.91 KBsaman malik
#23 Screenshot after .png123.4 KBambikahirode
#23 Screenshot ..before.png71.78 KBambikahirode
#22 interdiff_1345272_20-22.txt6.84 KBandregp
#22 1345272-22.patch9.31 KBandregp
#20 interdiff_19-20.txt380 bytesimmaculatexavier
#20 1345272-20.patch1.72 KBimmaculatexavier
#19 interdiff_18-19.txt466 bytesimmaculatexavier
#19 1345272-19.patch1.75 KBimmaculatexavier
#18 1345272-18.patch1.76 KBsuryakumar

Comments

Bojhan’s picture

Bojhan commented
Issue tags: -Needs usability review

The reason that triggers is not in workflow is beyond me, the reason action is not in workflow is because it would create a single item category for most sites. I am on the fence, about this one

ditcheva’s picture

ditcheva commented

I agree that these shouldn't be so scattered and I think they should all be in one place (including action), regardless of where that place is.

lpalgarvio’s picture

lpalgarvio commented

i agree with with putting Triggers and Actions under "workflow": admin/config/workflow
therefor, both stay next to Rules as well =)

go ahead with the patch, it's been a year...

and lets please backport to D7 too

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

catch’s picture

catch
he/him
Primary language English
commented
Title: actions, triggers, and workflow should be in the same menu path » Move 'actions' administration item under 'admin/config/workflow'
Component: user interface text » action.module
Issue summary: View changes
Issue tags: +Bug Smash Initiative

Triggers is no longer in core, but actions is still not under the workflow admin item.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +Novice
catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +Needs usability review

This could use UX team feedbak on whether the proposal to move the link is desirable or not - as Bojhan mentions it would create a 1-item admistrative category on a default install.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

suryakumar’s picture

suryakumar commented
Status: Active » Needs review
StatusFileSize
new 1345272-18.patch1.76 KB

Adding patch against 9.4.x

immaculatexavier’s picture

immaculatexavier commented
StatusFileSize
new 1345272-19.patch1.75 KB
new interdiff_18-19.txt466 bytes

Custom Commands have been fixed, and an interdiff against #18 has been attached.

immaculatexavier’s picture

immaculatexavier commented
StatusFileSize
new 1345272-20.patch1.72 KB
new interdiff_19-20.txt380 bytes

PHPCBF passed locally. Custom Commands have been fixed, and attached interdiff against #19 has been attached.

Status: Needs review » Needs work

The last submitted patch, 20: 1345272-20.patch, failed testing. View results

andregp’s picture

andregp commented
Status: Needs work » Needs review
StatusFileSize
new 1345272-22.patch9.31 KB
new interdiff_1345272_20-22.txt6.84 KB

Updated tests to use the new routes, I hope it makes it pass. I also updated the routes at the action.module file.

ambikahirode’s picture

ambikahirode commented
StatusFileSize
new Screenshot ..before.png71.78 KB
new Screenshot after .png123.4 KB

patch in #22 applies successfully and working fine for me on local 9.4.

RenatoCostaDev’s picture

RenatoCostaDev commented
Status: Needs review » Reviewed & tested by the community

Itested and works fine.

quietone’s picture

quietone commented
Issue summary: View changes
Issue tags: -Novice +Needs issue summary update

Reviewing RTBC issues to check they pass the core gates.

This issue is tagged 'Needs usability review' and I do not see a comment confirming that has happened. Setting to NW for that. It also needs an Issue Summary update, adding tag. All I did was add the standard template.

It is my understanding that someone working on this issue should take it to a Usability meeting but ask the folks in #ux for advice.

@ambikahirode, when making screenshots for an issue, add them to the Issue Summary so it is easier for the committer, or anyone else working on the issue. The before screenshot should show where the action links appear on the page.

A patch for D10 would is also needed.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs issue summary update +Novice

Still needs usability review, please reach out to the #ux channel to discuss presenting at the UX team meetings

saman malik’s picture

saman malik commented
StatusFileSize
new Before Patch..png46.91 KB
new AfterPatch.png18.16 KB

Verified and tested patch #22 on the drupal 9.4.x-dev version and the patch applied successfully and looks good to me.

Testing Steps:
1.Install drupal 9.4.x-dev version.
2.Install the workflow module.
3.Goto admin/config/workflow.
4.Apply the Patch and clear the cache.

Manibharathi E R’s picture

Manibharathi E R commented
StatusFileSize
new Before-Patch-1345272-22.png27.05 KB
new After-Patch-1345272-22.png42.86 KB

Patch #22 Verified and Applied successfully on both Drupal 9.4.x and Drupal 9.5.x.

Before Patch:
After-patch

After Patch:
Before-Patch

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Version: 9.4.x-dev » 10.1.x-dev
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Usability review

We discussed this issue at #3316853: Drupal Usability Meeting 2022-10-28. That issue will have a link to a recording of the meeting.

For the record, the attendees at today's usability meeting were @AaronMcHale, @benjifisher, @rkoller, @shaal, and @worldlinemine.

We were not sure whether to recommend this change. I think it would help a lot if the reason was explained more fully in the issue summary, so I am setting the status to NW and adding the tag for an issue summary update. To start, can we remove references to the Trigger module?

If I understand correctly, the main reason for suggesting the Workflows section of the menu is that the contrib Rules module puts its menu item there. The only thing that Drupal core puts there is configuration for the Content Moderation and Workflows modules, which does not seem closely related.

There does not seem to be a good reason for keeping Actions where it is, but I think we need a clearer reason for moving it.

Either way, we should also review how Actions are used in Drupal core, without the Rules module. The only thing I can think of is views that have a "bulk operations" field. That includes several admin views, such as those for /admin/content and /admin/people. Maybe Actions should be moved to Structure > Views.

quietone’s picture

quietone commented

Action module is approved for removal. See #3266458: [Policy] Deprecate Action (UI) module in D10 and move to contrib in D11

Normally, issues for an extension to be removed are postponed. However, because this has has a recent usability review, I will leave it open.

bhaveshithape’s picture

bhaveshithape commented
StatusFileSize
new 1345272-32.patch0 bytes
aaronmchale’s picture

aaronmchale
Primary language English
Location Edinburgh, Scotland
commented
Issue tags: -Needs usability review

Usability review provided in comment #30, removing tag.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Project: Drupal core » Action
Version: 11.x-dev » 1.x-dev
Component: action.module » Code
Category: Bug report » Feature request

the module moved to contrib project