It would be great to pull out some of the boilerplate defaults like font-size, color, etc into sass variables into the _settings.scss file.

It would take out the requirement of having to override these and just enable setting the values in the _settings.scss file. It also might be best practice to automatically have a _custom_settings.scss file (or something similar) for handling variables for a subtheme. I know people can just set that up themselves, so not a big deal, but it would be handy just to be available right from the start.

I've actually created a sass/compass version of the html5boilerplate for my non-Drupal sites, so I've already pulled out those variables into seperate files. There aren't that many of them, and if it is interesting to you, you can see it here: https://github.com/trexart/compass-html5boilerplate
I might pull all the boilerplate code back into a single file, with the variables, just as an example if that would be helpful.

Great job with this, I have been wanting something like this, but just haven't had the time to put it together. I've been using Tao with just manually putting in my sass/compass version of the html5boilerplate.

Comments

tsi’s picture

This actually sounds pretty cool, even though I don't really get the benefits. what is the difference between settings the font-size using SASS or using CSS ?
Can you please try to explain ?
Anyway, I agree that a single file will be much easier to maintain.

tsi’s picture

Status: Active » Closed (won't fix)

Probably won't be fixed unless there's a good reason for doing that.

ssherriff’s picture

Sorry about the long time between replies, thought I would receive an email on update and didn't.

Basically the main benefit is you have less lines of CSS. You aren't creating an extra line of CSS to change the font size, you are actually setting the font size where it was originally created. That extra line of overriding the original element doesn't have to take place.

Also, it makes it easy to know what exact base settings the boilerplate has originally set. You might not know off the top of your head on which element the font was set, or the font size. Basically to override you have to find out where it was set to make sure you are overriding the correct element. I know that isn't the end of the world, but it is just another step.

tsi’s picture

Status: Closed (won't fix) » Active

That actually makes sense, what are the changes to be done ? filename only ?

ssherriff’s picture

Hmm, not actually sure. I'm doing a theme at the moment using 965, and I've noticed that you've added the html5boilerplate just as a css file. That makes it a bit more difficult. Is there a particular reason why you don't have the html5boilerplate as a scss file so that it can be compiled in with the theme scss files to create one css file instead of 2?

I'll have a look, see if I can maybe create a patch you can look at to see if you want to make those sort of changes to the theme. Might not fit into your own plans.

tsi’s picture

Project: 965 » Sasson
Version: 7.x-2.0-beta4 » 7.x-2.x-dev

The SASS branch of 965 has a new home and is now called Sasson.

tsi’s picture

Status: Active » Closed (won't fix)

This will add maintenance overhead when updating the normalize stylesheet. we don't have time for that.