in working on the new signup limits feature (http://drupal.org/node/32482) i noticed there's some stale code and an extra DB query in signup_sign_up_user() which isn't necessary:

  • we already did a node_load(), so all the stuff from {signup} is already in the $node object, there's no need to query for all of that again.
  • the whole elaborate check to handle nodes that were created while the signup module was disabled is pointless now that http://drupal.org/node/49007 has been fixed.

attached patch for 5.x-2.* (currently HEAD). backport coming next.

CommentFileSizeAuthor
#2 signup_sign_up_user_cleanup_47x.patch.txt5.06 KBdww
#1 signup_sign_up_user_cleanup_5x-1.patch.txt4.98 KBdww
signup_sign_up_user_cleanup_5x-2.patch.txt4.9 KBdww

Comments

dww’s picture

dww
we/he/they
commented
StatusFileSize
new signup_sign_up_user_cleanup_5x-1.patch.txt4.98 KB

here's a 5.x-1.* version.

dww’s picture

dww
we/he/they
commented
StatusFileSize
new signup_sign_up_user_cleanup_47x.patch.txt5.06 KB

4.7.x version

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

after more testing... committed to HEAD, DRUPAL-5 and DRUPAL-4-7.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)