relation_save does not properly validate $type parameter

You can't create nodes of types that don't exist so imo this goes as a bug and should apply to relation_save() as well.

Attached patch adds type validation to relation_save() plus relation_type_load() $types param is now marked as optional.

#3: type_validation_with_tests-1345648-3.patch queued for re-testing.

reroll

reroll

relation_endpoint_field_validate() already does this:

  // Check that relation_type exists.
  if (!$relation_type) {
    $errors[$field['field_name']][$langcode][$delta][] = array(
      'error' => 'relation_nonexistent_type',
      'message' => t("The !relation_type relation type does not exist.", array('!relation_type' => $entity->relation_type)),
    );
  }

So instead of previous patch got to figure out why the code above is not working. For now it looks to be same bug as #1597770: Required fields are not attached on relation_save

Attached patch adds four tests, that try to create invalid relations: a relation with a non-existent relation type, a relation with invalid endpoints, a relation with a required field missing, and a relation with a field with invalid data. (The later two are for #1597770: Required fields are not attached on relation_save).

My understanding is that these should all fail at present, although if the field validation is working, then the latter two will only fail because the expected message is wrong. Let's see how it goes.

Again!

MOAR

Ok, this should do it. Fails properly if it succeeds!

Ok, notifiees, I'm gonna stop bugging you after this one - I figured out what I was doing wrong with my local tests, and this one is correct.

First 3 tests are failing because the relations are created, the fourth one is failing because the relation is being created, but there's a an SQLSTATE error due to the incorrect field data. So validation is failing in all cases.

Commited to the relation_validation_tests branch, incase anyone wants to work on it while I'm asleep. Good night!

Closed #1277762: Need general way to validate relations as a duplicate

There's potentially reasons why it might make sense to create an invalid relation, so relation_create should probably either throw a warning if the relation is invalid, or happily create invalid relations, while relation_save should throw a error.

Relation_create shouldnt be so strict on any passed default values, except for relation_type, which I think should throw an exception.

On save, the type can be rechecked to ensure it exists. Or throw invalid type exception.

If the relation does not have the correct number of endpoints, or incorrect type endpoints, then an integrity exception should be thrown.

I think create probably shouldn't do any checking. I can imagine a UI where the endpoints are selected first, and then on the next page, all possible matching relation types are given as options. Sounds unlikely, but it may have some kind of use..

Issue title was bad. There is no reason to validate anything in relation_create, but broken relations shouldn't get stored to database.

Right... relation_save

There is no relation_validate() :)

#2160525: "Field validation failed." - relations are not saved closed as duplicate of this. But now we have mixed arguments

should relation_save() validate more stuff or less? At the very least we need to add tests that verify what's the intended behaviour.