Hi there,

PayPal icons appears broken when showing the payment checkout pane, this occurs in a multilingual site with the path prefix mode.
The icons point within the path prefix and should aim at the root:
http://domain/en/sites/all/modules/commerce_paypal/images/paypal.gif (not found)

Any idea?
Thanks

CommentFileSizeAuthor
#9 1345822-paypal-icons-9.patch851 bytesamitaibu
#5 1345822-commerce-paypal-broken-icons.patch619 bytesnetsensei
#2 multilingual_paypal_icons_fix.patch797 bytes7thkey

Comments

it-cru’s picture

it-cru
Primary language English
Location Munich
commented

Subscribe ..the commerce module has the same problem with the icons of the payment status

7thkey’s picture

7thkey commented
Status: Active » Needs review
StatusFileSize
new multilingual_paypal_icons_fix.patch797 bytes

Hi there,

I send my first contribution that fix the url path to the paypal icons in a multilingual site.
Hope everything is ok with the patch.
Cheers

ñull’s picture

ñull commented
Status: Needs review » Reviewed & tested by the community

Works here!

PESTO3567’s picture

PESTO3567 commented

I think this could be easier done without using a global and just base_path() function?

netsensei’s picture

netsensei commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 1345822-commerce-paypal-broken-icons.patch619 bytes

New attempt with base_path(). This works for me.

ñull’s picture

ñull commented
Status: Needs review » Reviewed & tested by the community

Yes, works here too!

7thkey’s picture

7thkey commented

Ok with base_path().
Works here!!

mknapik’s picture

mknapik commented

This same problem occurred for me, but it was because I did not have Clean URLs enabled. The patch corrected the issue.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 1345822-paypal-icons-9.patch851 bytes

Using basepath() isn't better. Attached patch uses theme_image()

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Thanks, Amitai. Obviously much better. : )

For those above, the path you pass in should be relative to base_path(), and theme_image() uses file_create_url() to get the appropriate final URL for the image. Not using it in the first place was my bad. : P

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.