So, we're using the noderelationships module. We have a nodereference field. noderelationships lets you click a button from the nodereference, and it will open up a modalframe that lets you edit the referenced node inline.

It adds a submit handler that adds javascript to close the modalframe when you submit.

However, with workflow_extensions enabled, the submit handler doesn't get moved to the new buttons.

Here is a patch that makes sure to copy all the submit handlers to the new buttons. That way, if you're editing a referenced node, you can hit one of the submit buttons that sends it to a workflow state, and the modalframe will close.

CommentFileSizeAuthor
workflow_extensions_noderelationships.diff2.31 KBgalaxor

Comments

rdeboer’s picture

rdeboer
Location Melbourne
commented
Assigned: Unassigned » rdeboer

Thanks for the patch galaxor!
Rik

rdeboer’s picture

rdeboer
Location Melbourne
commented
Title: Integration with noderelationships + modalframe » Workflow Extensions integration with noderelationships + modalframe

Darn.... forgot to include this patch when releasing 6.x-1.7.
Will add to 6.x-1.x dev branch.

rdeboer’s picture

rdeboer
Location Melbourne
commented

Looking at the patch code, it seems that the condition ($form['#id'] == 'node-form') has gone from _workflow_extensions_assign_handlers($form) ?
Is that intentional?

I'm happy with the changes regarding the weight increase of Workflow Extensions to come after NodeRelationships.

rdeboer’s picture

rdeboer
Location Melbourne
commented
Status: Needs review » Closed (won't fix)

Question in #3 not answered.
Closing due to inactivity.