We should be able to update the library from the command line, or copy the module's included library to the sites/all/libraries when someone uses the Libraries API.

CommentFileSizeAuthor
#3 1346122-rjsdl-3.patch3.24 KBrupl
#1 1346122-responddrush.1.patch3.11 KBcluther

Comments

cluther’s picture

cluther
Primary language English
Location Austin, Texas
commented
StatusFileSize
new 1346122-responddrush.1.patch3.11 KB

here ya go. Code modeled after drush implementation of rdfx. Having problems getting it to execute on my box.

cluther’s picture

cluther
Primary language English
Location Austin, Texas
commented
Status: Active » Needs review

whoops - forget to set to needs review.

rupl’s picture

rupl
he/him
Primary language English
commented
Title: Drush support » Add a Drush command to download repsond.js library
StatusFileSize
new 1346122-rjsdl-3.patch3.24 KB

Thanks, this is a great start! I made a few changes to produce the attached patch:

  • Rewrote path logic in download callback. respondjs_get_library_path() always assumes the library has been downloaded so it was delivering false positives.
  • Rewrote download code to remove some remaining bits of RDFx command. Thanks for the help, Stéphane!

This seems to work great on my local but I'd like confirmation from someone else. Just a note, I initially had problems due to an old version of wget. I had to upgrade to 1.12 because 1.9 didn't have --no-check-certificate.

To test, I ran the command twice. Once when Libraries was disabled and then again with it enabled. When those were successful, I tried enabling the respondjs module two more times, again with Libraries disabled and then enabled.

rupl’s picture

rupl
he/him
Primary language English
commented
Status: Needs review » Fixed

Committed to 7.x-1.x - 534d568 and 794438e

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.