Overflow is currently hidden in the main content area, which results in difficulty with popup/mouseover widgets such as tool tips or the Tidy node links widget.

Let's make overflow visible in general.

CommentFileSizeAuthor
#5 footer_overflow-1346546-5.patch1.08 KBlightsurge
#4 footer_overflow-1346546-4.patch1.09 KBlightsurge
#3 footer_overflow-1346546-3.patch1012 byteslightsurge
#1 bottomofpage2.png7.97 KBlightsurge

Comments

lightsurge’s picture

lightsurge commented
StatusFileSize
new bottomofpage2.png7.97 KB

In terms of the tidy node links widget, the overflow issue could be a problem for situations where the drop-down is at the very bottom of the page e.g. http://drupal.org/files/bottomofpage2_0.png

Adding 

.row, .nested, .block {
overflow: visible;
}

to commons origins local.css makes the dropdown overflow visible (though may have other adverse affects), but it doesn't help the fact that if we're at the bottom of the page, there's no space to overflow onto.

Either we'd have to enter a minimum height for the bottom of the content region, or have the drop-downs drop-UP instead in these circumstances (Edit: or, I suppose, we should make sure there's something in the footer)?

ezra-g’s picture

ezra-g commented

Thanks for the tip, @lightsurge!

I think this change is appropriate for commons_origins-style.css since it's applicable to all sites running Commons Origins.

I made the change there and while it increased the amount of the Tidy node links dropdown widget that's visible, the dropdown is still truncated by the footer:

Only local images are allowed.

So, this is a huge improvement but seems like we need to tweak some other css.

While it doesn't address the issue in the screenshot, perhaps we should revise:

.sidebar-first .block .content, 
.sidebar-last .block .content {
	overflow: hidden;
}
lightsurge’s picture

lightsurge commented
StatusFileSize
new footer_overflow-1346546-3.patch1012 bytes

Can you guarantee Commons users would have a footer? I'm not using one.

Another option is to ensure that the postscript-top region always renders, and apply a minimum height to it.

Here's a patch (not really for review, just so you can see what I'm on about).

lightsurge’s picture

lightsurge commented
StatusFileSize
new footer_overflow-1346546-4.patch1.09 KB

Actually this would probably be better done in node-bottom, figure it's only in nodes that we'll have these dropdowns right?

lightsurge’s picture

lightsurge commented
StatusFileSize
new footer_overflow-1346546-5.patch1.08 KB

Last patch is pants, putting space in node-bottom pushes things like comments down. Below is probably the best at this approach, because it only adds space to preface-top only in the context of a node, only when that node is not a group, and only when it doesn't have any comments (in which case the extra space is not necessary).

lsolesen’s picture

lsolesen commented
Version: » 6.x-2.22
Issue summary: View changes