I'm very new to Drupal, Fusion, and Superfish, and I'm not certain if this is an issue with Fusion or Superfish. I'm not even certain how to describe the format issues I'm seeing, so feel free to take a look at the Home/Astronomy Galleries menu on the front page of my site: http://www.morningcynic.com/

In short, it appears that there are several formatting issues causing the menu elements to not line up with... the background of menu elements? Too much padding, mis-configured margins? I located one style, in fusion-core-skins.css:

ul.sf-vertical li a:link, ul.sf-vertical li a:visited, ul.sf-vertical li .nolink {
margin-left: 10px;
padding: 2px;
}

Setting margin-left to 0 aligns the left edge correctly, but there are many other issues.

Any help would be appreciated.

CommentFileSizeAuthor
#4 fusion-core-remove-superfish-styles.patch2.03 KBsheena_d

Comments

sheena_d’s picture

sheena_d commented
Title: Superfish dropdown formatting issue » Remove default Superfish styling and Superfish-related skins from Fusion Core
Assigned: Unassigned » sheena_d
Category: support » task
Status: Active » Needs work

Thanks for pointing this out. Superfish menus used to be included as part of Fusion Core (in Drupal 6) and this CSS is leftover from that implementation. Now that we're not directly delivering the Superfish functionality via Fusion, we should probably strip out all styling for it and references to it from the theme, allowing users to utilize the themes included with the Superfish module if they choose..

@aquariumtap: what do you think? Do you see any potential issues with doing this? It will most likely have a negative impact on superfish menus in sub-themes that have compensated for the CSS in Fusion Core, but will only require minor updates to sub-themes. If you don't see any problems with doing this, I will roll the patch and test with our sub-themes so we can add some extra instructions to the change log for any updates that will need to be made to sub-themes.

honigferd’s picture

honigferd commented

Getting this fixed would be rather nice, as Superfish in Fusion right now is an absolute nightmare to use. :(

sheena_d’s picture

sheena_d commented
Status: Needs work » Needs review

@honigferd - the latest dev release of Fusion core should fix any issues you are having.

sheena_d’s picture

sheena_d commented
Version: 7.x-2.0-alpha1 » 7.x-2.x-dev
StatusFileSize
new fusion-core-remove-superfish-styles.patch2.03 KB

There were a few superfish styles left behind. The attached patch removes those styles from 7.x-2.x-dev

sheena_d’s picture

sheena_d commented
Status: Needs review » Fixed

This fix is included in Fusion 7.x-2.0-beta2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit ecb1fd2 on master, 7.x-2.x by sheena_d: 
    #1346552 removing obsolete Superfish styling