Related issue: http://drupal.org/node/356379#comment-2899174

On user/[uid]/edit/twitter page, when one user has a twitter account linked and then the user remove it, history of tweets on "twitter" table should be deleted.

CommentFileSizeAuthor
#5 twitter-1346744.patch1.74 KBjonhattan
#4 twitter-1346744.patch1.45 KBjonhattan
#1 delele-tweets-history-1346744-1.patch496 bytestoleillo

Comments

toleillo’s picture

toleillo commented
Status: Active » Needs review
StatusFileSize
new delele-tweets-history-1346744-1.patch496 bytes

Patch to delete history of tweets.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Status: Needs review » Reviewed & tested by the community

Works as expected.

/me working on a patch for d7.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Status: Reviewed & tested by the community » Needs work

It should delete user's timeline in despite $screen_name is null. OTOH It seems $screen_name always has a value. Will ask juampy

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Assigned: toleillo » Unassigned
Status: Needs work » Needs review
StatusFileSize
new twitter-1346744.patch1.45 KB

Patch for d6.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
StatusFileSize
new twitter-1346744.patch1.74 KB

Patch for d7.

steinmb’s picture

steinmb commented
Status: Needs review » Fixed

This got committed so no need for review?

commit 66242debf7e9b7b77a7d44283cc88312a7e320cf
Author: jonhattan <jonhattan@49817.no-reply.drupal.org>
Date:   Sat Nov 19 16:10:32 2011 +0100

    Issue #1346744 by toleillo and jonhattan: Delete twitter account history on remove account action
    
    Applied patch provided by jonhattan.
jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Fixed » Needs review

Still pending to commit to 7.x

juampynr’s picture

juampynr commented
Status: Needs review » Fixed

Applied johnattan's patch in 7.x-3.x with a small fix on twitter_account_delete ($account->screen_name instead of $account['screen_name']).

Twitter account info and tweets are now being deleted. Thanks toleillo, johnattan and steimbd for the good job.

http://drupalcode.org/project/twitter.git/commitdiff/14784629326f4947cac...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.